doc/asm: document go_asm.h only works in the runtime package #33069

PureWhiteWu · 2019-07-12T04:50:18Z

gopherbot · 2019-07-12T04:51:41Z

This PR (HEAD: 8bfbf53) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/185917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-12T04:53:13Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-12T04:55:57Z

This PR (HEAD: de3f7ab) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/185917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-12T14:50:41Z

Message from Cherry Zhang:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-12T20:49:55Z

Message from White Pure:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-16T04:43:51Z

Message from White Pure:

Patch Set 2:

Hi, what's the status of this patch now?

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-23T02:45:40Z

Message from White Pure:

Patch Set 2:

Hi, is there anything wrong with this patch?

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-23T03:24:18Z

Message from Agniva De Sarker:

Patch Set 2:

Patch Set 2:

Hi, is there anything wrong with this patch?

There is nothing wrong. This is an open-source project. Sometimes maintainers take time to reply back. Give it some time.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-23T03:32:04Z

Message from White Pure:

Patch Set 2:

Patch Set 2:

Patch Set 2:

Hi, is there anything wrong with this patch?

There is nothing wrong. This is an open-source project. Sometimes maintainers take time to reply back. Give it some time.

okay, thanks. I was worrying if there's any problem in this patch.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-23T06:58:51Z

Message from Rob Pike:

Patch Set 2:

I am not comfortable reviewing this for correctness, only style.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-24T04:44:28Z

Message from Ian Lance Taylor:

Patch Set 2:

Cherry, does the text look correct to you? It seems correct to me.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-24T08:38:10Z

Message from Cherry Zhang:

Patch Set 2:

(1 comment)

Patch Set 2:

Cherry, does the text look correct to you? It seems correct to me.

It looks correct to me as well. I left a comment about where to put the go_asm.h part.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-07-24T11:01:03Z

This PR (HEAD: 9c389b9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/185917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-24T11:06:56Z

Message from White Pure:

Patch Set 3:

(1 comment)

Added some hint in the "Note" section.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-11T03:15:59Z

Message from White Pure:

Patch Set 3:

Ping, don't forget this patch~
Thanks~

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-11T04:53:30Z

Message from Rob Pike:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-11T05:26:01Z

This PR (HEAD: 886c769) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/185917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-08-11T05:28:47Z

Message from White Pure:

Patch Set 4:

(1 comment)

Fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-11T05:30:39Z

Message from Rob Pike:

Patch Set 4:

(2 comments)

One last change please.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-11T05:33:41Z

This PR (HEAD: 498a299) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/185917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-08-11T05:34:38Z

Message from White Pure:

Patch Set 4:

(2 comments)

Done.

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-11T05:36:30Z

Message from Rob Pike:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/185917.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-08-11T05:37:33Z

This PR (HEAD: a7208c8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/185917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Fixes #33054 Change-Id: I687d45e092d721a6c22888cc7ddbe420c16a5af9 GitHub-Last-Rev: a7208c8 GitHub-Pull-Request: #33069 Reviewed-on: https://go-review.googlesource.com/c/go/+/185917 Reviewed-by: Rob Pike <[email protected]>

agnivade · 2019-08-11T09:00:24Z

The CL was merged.

issue #33054: document go_asm.h only works in the runtime package

8bfbf53

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 12, 2019

PureWhiteWu mentioned this pull request Jul 12, 2019

doc/asm: clarify that get_tls only works in runtime package #33054

Closed

fix grammer

de3f7ab

add hint for go_tls.h and go_asm.h

9c389b9

rephrase sentence && fix grammer

886c769

fix grammar mistakes

498a299

add comma

a7208c8

agnivade closed this Aug 11, 2019

doc/asm: document go_asm.h only works in the runtime package #33069

doc/asm: document go_asm.h only works in the runtime package #33069

Uh oh!

Conversation

PureWhiteWu commented Jul 12, 2019

Uh oh!

gopherbot commented Jul 12, 2019

Uh oh!

gopherbot commented Jul 12, 2019

Uh oh!

gopherbot commented Jul 12, 2019

Uh oh!

gopherbot commented Jul 12, 2019

Uh oh!

gopherbot commented Jul 12, 2019

Uh oh!

gopherbot commented Jul 16, 2019

Uh oh!

gopherbot commented Jul 23, 2019

Uh oh!

gopherbot commented Jul 23, 2019

Uh oh!

gopherbot commented Jul 23, 2019

Uh oh!

gopherbot commented Jul 23, 2019

Uh oh!

gopherbot commented Jul 24, 2019

Uh oh!

gopherbot commented Jul 24, 2019

Uh oh!

gopherbot commented Jul 24, 2019

Uh oh!

gopherbot commented Jul 24, 2019

Uh oh!

gopherbot commented Aug 11, 2019

Uh oh!

gopherbot commented Aug 11, 2019

Uh oh!

gopherbot commented Aug 11, 2019

Uh oh!

gopherbot commented Aug 11, 2019

Uh oh!

gopherbot commented Aug 11, 2019

Uh oh!

gopherbot commented Aug 11, 2019

Uh oh!

gopherbot commented Aug 11, 2019

Uh oh!

gopherbot commented Aug 11, 2019

Uh oh!

gopherbot commented Aug 11, 2019

Uh oh!

agnivade commented Aug 11, 2019

Uh oh!

Uh oh!