net/http: fix spelling mistake in a comment #28907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

haormj wants to merge 1 commit into golang:master from haormj:master

haormj commented Nov 21, 2018 •

edited

Loading

Fixes #28904


          net/http: spelling mistake in a comment

3a7865a

Fixes golang#28904

googlebot added the cla: yes label

Contributor

gopherbot commented Nov 21, 2018

This PR (HEAD: 3a7865a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/150737 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Nov 21, 2018

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/150737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2018

Message from Daniel Martí:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/150737.
After addressing review feedback, remember to publish your drafts!

mvdan changed the title ~~net/http: spelling mistake in a comment~~ net/http: fix spelling mistake in a comment

Contributor

gopherbot commented Nov 21, 2018

Message from Daniel Martí:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/150737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2018

Message from Daniel Martí:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/150737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2018

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=3ebad985

Please don’t reply on this GitHub thread. Visit golang.org/cl/150737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 21, 2018

Message from Gobot Gobot:

Patch Set 3: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/150737.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          net/http: fix spelling mistake in a comment

c648485

Fixes #28904

Change-Id: I8d416c47479a266735a39c926fd2f0f2bb25d57b
GitHub-Last-Rev: 3a7865a
GitHub-Pull-Request: #28907
Reviewed-on: https://go-review.googlesource.com/c/150737
Reviewed-by: Daniel Martí <[email protected]>
Run-TryBot: Daniel Martí <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>

Contributor

gopherbot commented Nov 21, 2018

This PR is being closed because golang.org/cl/150737 has been merged.

gopherbot closed this

bradfitz pushed a commit that referenced this pull request


          net/http: fix spelling mistake in a comment

4a8ce14

Fixes #28904

Change-Id: I8d416c47479a266735a39c926fd2f0f2bb25d57b
GitHub-Last-Rev: 3a7865a
GitHub-Pull-Request: #28907
Reviewed-on: https://go-review.googlesource.com/c/150737
Reviewed-by: Daniel Martí <[email protected]>
Run-TryBot: Daniel Martí <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels