-
Notifications
You must be signed in to change notification settings - Fork 18k
html/template: document that comments are stripped from html templates #28733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The exsisting documentaion doesn't document that the comments are stripped from html templates after they are parsed. This patch tries to document the behavior and provide a rationale along with a workaround for that. Fixes #28628
This PR (HEAD: 08bd49a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/148833 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/148833. |
Message from Kuntal Majumder: Patch Set 1:
The issue required the explanation and a possible workaround, what would be the best possible place to put them? Please don’t reply on this GitHub thread. Visit golang.org/cl/148833. |
Message from Ian Lance Taylor: Patch Set 1:
It may be appropriate to add something to the package docs. Or better might be to add an example. Note that we don't have to do exactly what the issue says, we have to find the right fix. Thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/148833. |
Message from Kuntal Majumder: Patch Set 1:
Ohh, sure, will reformat the patch accordingly Thanks Please don’t reply on this GitHub thread. Visit golang.org/cl/148833. |
Message from Andrew Ekstedt: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/148833. |
Moved the rationale and workaround from template.Parse()'s documentation to the package documentation, provided the link of the issue for more information.
This PR (HEAD: f682ca8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/148833 to see it. Tip: You can toggle comments from me using the |
Message from Roberto Clapis: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/148833. |
53bd915
to
6139019
Compare
4a7ed1f
to
0f992b9
Compare
Message from USE [email protected] instead: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/148833. |
The existing documentation doesn't document that the comments are
stripped from HTML templates after they are parsed. This patch tries
to document the behavior and provide a rationale along with a workaround
for that.
Fixes #28628