Skip to content

html/template: document that comments are stripped from html templates #28733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

html/template: document that comments are stripped from html templates #28733

wants to merge 2 commits into from

Conversation

hellozee
Copy link
Contributor

The existing documentation doesn't document that the comments are
stripped from HTML templates after they are parsed. This patch tries
to document the behavior and provide a rationale along with a workaround
for that.

Fixes #28628

The exsisting documentaion doesn't document that the comments are
stripped from html templates after they are parsed. This patch tries
to document the behavior and provide a rationale along with a workaround
for that.

Fixes #28628
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 12, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: 08bd49a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/148833 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/148833.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Kuntal Majumder:

Patch Set 1:

Patch Set 1:

(1 comment)

The issue required the explanation and a possible workaround, what would be the best possible place to put them?


Please don’t reply on this GitHub thread. Visit golang.org/cl/148833.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

The issue required the explanation and a possible workaround, what would be the best possible place to put them?

It may be appropriate to add something to the package docs. Or better might be to add an example.

Note that we don't have to do exactly what the issue says, we have to find the right fix.

Thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/148833.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Kuntal Majumder:

Patch Set 1:

Patch Set 1:

The issue required the explanation and a possible workaround, what would be the best possible place to put them?

It may be appropriate to add something to the package docs. Or better might be to add an example.

Note that we don't have to do exactly what the issue says, we have to find the right fix.

Thanks.

Ohh, sure, will reformat the patch accordingly

Thanks


Please don’t reply on this GitHub thread. Visit golang.org/cl/148833.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Ekstedt:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/148833.
After addressing review feedback, remember to publish your drafts!

Moved the rationale and workaround from template.Parse()'s
documentation to the package documentation, provided the link
of the issue for more information.
@gopherbot
Copy link
Contributor

This PR (HEAD: f682ca8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/148833 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Roberto Clapis:

Patch Set 2:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/148833.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 2 times, most recently from 53bd915 to 6139019 Compare October 3, 2019 21:09
@gopherbot gopherbot force-pushed the master branch 6 times, most recently from 4a7ed1f to 0f992b9 Compare November 5, 2019 02:57
@gopherbot
Copy link
Contributor

Message from USE [email protected] instead:

Patch Set 2:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/148833.
After addressing review feedback, remember to publish your drafts!

@heschi heschi closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html/template: document that it strips comments
4 participants