cmd/link, runtime: add initial cgo support for ppc64 #28546

zte-majiang · 2018-11-02T07:04:13Z

We should be able to build docker after this get applied.

googlebot · 2018-11-02T07:04:15Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-11-02T07:21:42Z

CLAs look good, thanks!

gopherbot · 2018-11-02T07:26:31Z

This PR (HEAD: 5b1ff45) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/146898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-11-02T07:27:19Z

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-02T12:46:09Z

Message from Gerrit User 15676:

Patch Set 1:

Do we really want to be putting our function descriptors in .text? I guess for static linking (and without static PIE) it's fine, but might be better to put it in .data.rel.ro, if not .opd?

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-02T12:56:23Z

Message from Gerrit User 5206:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-02T13:10:29Z

Message from Gerrit User 6320:

Patch Set 1:

(3 comments)

Patch Set 1:

Do we really want to be putting our function descriptors in .text? I guess for static linking (and without static PIE) it's fine, but might be better to put it in .data.rel.ro, if not .opd?

I think it would be best to be consistent with other ppc64 compilers and put them in the .opd.

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-02T13:16:16Z

Message from Gerrit User 6320:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-02T16:03:09Z

Message from Gerrit User 29664:

Patch Set 1:

(5 comments)

Patch Set 1:

(3 comments)

Patch Set 1:

Do we really want to be putting our function descriptors in .text? I guess for static linking (and without static PIE) it's fine, but might be better to put it in .data.rel.ro, if not .opd?

I think it would be best to be consistent with other ppc64 compilers and put them in the .opd.

Shall we fix the problem in this patch?

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-02T16:13:09Z

This PR (HEAD: 8c8173a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/146898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-11-02T16:13:37Z

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-02T16:15:45Z

This PR (HEAD: d2512b9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/146898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-11-08T14:42:04Z

Message from Gerrit User 29664:

Patch Set 3: Code-Review+1

Hi, I have updated the patch a few days ago. It is ok now?

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-08T14:57:56Z

Message from Gerrit User 6320:

Patch Set 3:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-08T17:08:15Z

Message from Gerrit User 6320:

Patch Set 3:

You might want to also look at what tests in cmd/dist/test.go that are current disabled for linux/ppc64 that could be enabled with this change.

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-09T15:22:12Z

Message from Ian Lance Taylor:

Patch Set 3:

Please update the commit message as I requested earlier. Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-10T15:03:46Z

Message from Jiang Ma:

Patch Set 3:

Patch Set 3:

Please update the commit message as I requested earlier. Thanks.

Hi, I'm sorry but I have changed the commit message on github(see d2512b9).
It looks like the GerritBot did not pull the message changes(see https://go-review.googlesource.com/c/go/+/146898/3//COMMIT_MSG#4).
What should I do, if I want to correct the commit message here?

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-10T22:13:25Z

Message from Ian Lance Taylor:

Patch Set 3:

Please update the commit message as I requested earlier. Thanks.

Hi, I'm sorry but I have changed the commit message on github(see d2512b9).
It looks like the GerritBot did not pull the message changes(see https://go-review.googlesource.com/c/go/+/146898/3//COMMIT_MSG#4).
What should I do, if I want to correct the commit message here?

You need to edit the title and first comment of the Github pull request at #28546 . Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-11T16:41:16Z

Message from Jiang Ma:

Patch Set 4:

(3 comments)

Patch Set 3:

Please update the commit message as I requested earlier. Thanks.

Hi, I'm sorry but I have changed the commit message on github(see d2512b9).
It looks like the GerritBot did not pull the message changes(see https://go-review.googlesource.com/c/go/+/146898/3//COMMIT_MSG#4).
What should I do, if I want to correct the commit message here?

You need to edit the title and first comment of the Github pull request at #28546 . Thanks.

Thanks, It's OK now :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-12T09:05:29Z

Message from Clément Chigot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-12T13:44:36Z

Message from Lynn Boger:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-13T14:47:46Z

This PR (HEAD: 888df3f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/146898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-11-13T14:53:30Z

This PR (HEAD: ce7068b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/146898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-11-13T15:15:26Z

Message from Jiang Ma:

Patch Set 6: Code-Review+1

(2 comments)

Patch Set 3:

You might want to also look at what tests in cmd/dist/test.go that are current disabled for linux/ppc64 that could be enabled with this change.

Thanks for the advice. I have take a quick look at cmd/dist/test.go, it seems that the change is not as easy as I expected.
As our final goal is to make ppc64 support most features of ppc64le(such as cgo), I think we could do it step by step. Let's try to enable tests next time, shall we?

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-13T15:59:33Z

Message from Lynn Boger:

Patch Set 6:

Patch Set 6: Code-Review+1

(2 comments)

Patch Set 3:

You might want to also look at what tests in cmd/dist/test.go that are current disabled for linux/ppc64 that could be enabled with this change.

Thanks for the advice. I have take a quick look at cmd/dist/test.go, it seems that the change is not as easy as I expected.
As our final goal is to make ppc64 support most features of ppc64le(such as cgo), I think we could do it step by step. Let's try to enable tests next time, shall we?

That's fine. After looking further, I can see it is more complicated that I thought.

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-13T16:11:56Z

Message from Jiang Ma:

Patch Set 6:

(1 comment)

Patch Set 4:

(1 comment)
It this OK for AIX?

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-14T12:29:15Z

Message from Clément Chigot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

We should be able to build docker after this get applied. Updates golang#13192

gopherbot · 2018-11-16T15:40:03Z

This PR (HEAD: 210b7bc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/146898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-11-16T15:44:00Z

Message from Jiang Ma:

Patch Set 7: Code-Review+1

(1 comment)

Hi all,
I have fix all the problems. Is this patch OK for everyone now?

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-19T08:05:44Z

Message from Clément Chigot:

Patch Set 7: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-19T08:47:11Z

Message from Tobias Klauser:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-19T08:47:12Z

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=af7630f1

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-19T08:56:38Z

Message from Gobot Gobot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-19T16:16:27Z

Message from Lynn Boger:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-20T08:05:26Z

Message from Clément Chigot:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-20T13:32:24Z

Message from Lynn Boger:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-20T14:45:56Z

Message from Lynn Boger:

Patch Set 7: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-11-20T14:46:23Z

Message from Lynn Boger:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/146898.
After addressing review feedback, remember to publish your drafts!

We should be able to build docker after this get applied. Updates #13192 Change-Id: I5378d3518fac52d6bd4c97828884c1b382b7ace5 GitHub-Last-Rev: 210b7bc GitHub-Pull-Request: #28546 Reviewed-on: https://go-review.googlesource.com/c/146898 Reviewed-by: Jiang Ma <[email protected]> Reviewed-by: Clément Chigot <[email protected]> Reviewed-by: Lynn Boger <[email protected]> Run-TryBot: Tobias Klauser <[email protected]> Run-TryBot: Lynn Boger <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

gopherbot · 2018-11-20T14:51:24Z

This PR is being closed because golang.org/cl/146898 has been merged.

We should be able to build docker after this get applied. Updates #13192 Change-Id: I5378d3518fac52d6bd4c97828884c1b382b7ace5 GitHub-Last-Rev: 210b7bc GitHub-Pull-Request: #28546 Reviewed-on: https://go-review.googlesource.com/c/146898 Reviewed-by: Jiang Ma <[email protected]> Reviewed-by: Clément Chigot <[email protected]> Reviewed-by: Lynn Boger <[email protected]> Run-TryBot: Tobias Klauser <[email protected]> Run-TryBot: Lynn Boger <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Nov 2, 2018

zte-majiang force-pushed the master branch from e5fc39d to 5b1ff45 Compare November 2, 2018 07:21

googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Nov 2, 2018

zte-majiang force-pushed the master branch from 5b1ff45 to 8c8173a Compare November 2, 2018 16:12

zte-majiang force-pushed the master branch from 8c8173a to d2512b9 Compare November 2, 2018 16:15

zte-majiang changed the title ~~cgo: add initial support for ppc64~~ cmd/link, runtime: add initial cgo support for ppc64 Nov 11, 2018

zte-majiang force-pushed the master branch from d2512b9 to 888df3f Compare November 13, 2018 14:47

zte-majiang force-pushed the master branch from 888df3f to ce7068b Compare November 13, 2018 14:50

cmd/link, runtime: add initial cgo support for ppc64

210b7bc

We should be able to build docker after this get applied. Updates golang#13192

zte-majiang force-pushed the master branch from ce7068b to 210b7bc Compare November 16, 2018 15:39

gopherbot closed this Nov 20, 2018

cmd/link, runtime: add initial cgo support for ppc64 #28546

cmd/link, runtime: add initial cgo support for ppc64 #28546

Uh oh!

Conversation

zte-majiang commented Nov 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Nov 2, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 2, 2018

Uh oh!

gopherbot commented Nov 8, 2018

Uh oh!

gopherbot commented Nov 8, 2018

Uh oh!

gopherbot commented Nov 8, 2018

Uh oh!

gopherbot commented Nov 9, 2018

Uh oh!

gopherbot commented Nov 10, 2018

Uh oh!

gopherbot commented Nov 10, 2018

Uh oh!

gopherbot commented Nov 11, 2018

Uh oh!

gopherbot commented Nov 12, 2018

Uh oh!

gopherbot commented Nov 12, 2018

Uh oh!

gopherbot commented Nov 13, 2018

Uh oh!

gopherbot commented Nov 13, 2018

Uh oh!

gopherbot commented Nov 13, 2018

Uh oh!

gopherbot commented Nov 13, 2018

Uh oh!

gopherbot commented Nov 13, 2018

Uh oh!

gopherbot commented Nov 14, 2018

Uh oh!

gopherbot commented Nov 16, 2018

Uh oh!

gopherbot commented Nov 16, 2018

Uh oh!

gopherbot commented Nov 19, 2018

Uh oh!

gopherbot commented Nov 19, 2018

Uh oh!

gopherbot commented Nov 19, 2018

Uh oh!

gopherbot commented Nov 19, 2018

Uh oh!

gopherbot commented Nov 19, 2018

Uh oh!

gopherbot commented Nov 20, 2018

Uh oh!

zte-majiang commented Nov 2, 2018 •

edited

Loading