-
Notifications
You must be signed in to change notification settings - Fork 18.1k
os: add ExitCode method to ProcessState #26544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ac9e11f
to
5832c3b
Compare
Message from Gerrit User 12446: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 12446: Uploaded patch set 4: New patch set was added with same tree, parent, and commit message as Patch Set 3. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 5065: Patch Set 4: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 12446: Uploaded patch set 5: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 12446: Uploaded patch set 6: New patch set was added with same tree, parent, and commit message as Patch Set 5. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
5832c3b
to
b930fe2
Compare
Message from Gerrit User 12446: Uploaded patch set 8: New patch set was added with same tree, parent, and commit message as Patch Set 7. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
b930fe2
to
fb18cda
Compare
Message from Gerrit User 12446: Uploaded patch set 10: New patch set was added with same tree, parent, and commit message as Patch Set 9. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 12446: Uploaded patch set 11: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 12446: Uploaded patch set 12: New patch set was added with same tree, parent, and commit message as Patch Set 11. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 24740: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 28469: Patch Set 12: (1 comment) Will need docs about when it returns -1. Also, I'm not on the Go team, but I presume this will need tests added -- not sure whether it should go in os_test.go or exec_test.go. There's already a TestExitStatus() function in exec_test.go, so maybe there. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
fb18cda
to
4cde72e
Compare
Message from Gerrit User 12446: Uploaded patch set 14: New patch set was added with same tree, parent, and commit message as Patch Set 13. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 28469: Patch Set 14: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
4cde72e
to
1174a73
Compare
Message from Gerrit User 12446: Uploaded patch set 16: New patch set was added with same tree, parent, and commit message as Patch Set 15. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 24740: Patch Set 14:
Yes, you are right, thank you for pointing out. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
0090c13
to
8fbbf63
Compare
Message from Gerrit User 24740: Patch Set 16:
Is there any other I need to update? Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 5065: Patch Set 16: Wang, the tree is currently closed. Somebody will look at this when the tree opens next week or so. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 5065: Patch Set 16: Run-TryBot+1 Code-Review+2 RELNOTE=yes Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 5976: Patch Set 16: TryBots beginning. Status page: https://farmer.golang.org/try?commit=f6ef340a Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 5976: Patch Set 16: Build is still in progress... Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 5065: Patch Set 16: Code-Review+1 This needs to be fixed on Windows. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 5976: Patch Set 16: TryBot-Result-1 2 of 19 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 28469: Patch Set 16: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
1174a73
to
0b5262d
Compare
Message from Gerrit User 5065: Patch Set 17: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 5976: Patch Set 17: TryBots beginning. Status page: https://farmer.golang.org/try?commit=20b04604 Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
Message from Gerrit User 5976: Patch Set 17: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/125443. |
This PR is being closed because golang.org/cl/125443 has been merged. |
Fixes #26539 Change-Id: I6d403c1bbb552e1f1bdcc09a7ccd60b50617e0fc GitHub-Last-Rev: 0b5262d GitHub-Pull-Request: #26544 Reviewed-on: https://go-review.googlesource.com/125443 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
Fixes #26539