Skip to content

time: add clarification to Timer.Stop documentation #26293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

time: add clarification to Timer.Stop documentation #26293

wants to merge 4 commits into from

Conversation

conspicuousClockwork
Copy link
Contributor

Fixes #26220

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 9, 2018
@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Caleb Martinez:

Patch Set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Caleb Martinez:

Patch Set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 5: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 5:

Gerrit Bot is fighting you. If you started with a Pull Request, you have to continue using Pull Requests, not Gerrit directly.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@conspicuousClockwork conspicuousClockwork changed the title time/tick: add clarification to Stop() documentation time: add clarification to Time.Stop documentation Jul 9, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 6: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 7: New patch set was added with same tree, parent, and commit message as Patch Set 6.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 8: New patch set was added with same tree, parent, and commit message as Patch Set 7.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 9: New patch set was added with same tree, parent, and commit message as Patch Set 8.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Caleb Martinez:

Patch Set 5:

(1 comment)

Patch Set 5:

Gerrit Bot is fighting you. If you started with a Pull Request, you have to continue using Pull Requests, not Gerrit directly.

Whoops, thank you again for the feedback.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 9: Code-Review+2

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 10: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 11: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 11: -Code-Review

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 13: New patch set was added with same tree, parent, and commit message as Patch Set 12.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 13:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@conspicuousClockwork conspicuousClockwork changed the title time: add clarification to Time.Stop documentation time: add clarification to Timer.Stop documentation Jul 10, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 15: New patch set was added with same tree, parent, and commit message as Patch Set 14.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 16: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 17: New patch set was added with same tree, parent, and commit message as Patch Set 16.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Caleb Martinez:

Patch Set 17:

(3 comments)

Whoops, fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rob Pike:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 19: New patch set was added with same tree, parent, and commit message as Patch Set 18.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Caleb Martinez:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rob Pike:

Patch Set 19:

I like this rewrite, but then I provided the text. Thanks for putting it and keeping the CL alive.

If someone other than me wants to approve it, this could land and an issue would be closed.

Thank you for your forbearance.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 19: Code-Review+2

Thanks for your patience.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122715.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jul 11, 2018
@conspicuousClockwork @ianlancetaylor
time: add clarification to Timer.Stop documentation
a07ee41 
Fixes #26220

Change-Id: I05703912be594d985ad3ccb3a9757ae21ec738ab
GitHub-Last-Rev: e464984
GitHub-Pull-Request: #26293
Reviewed-on: https://go-review.googlesource.com/122715
Reviewed-by: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/122715 has been merged.

@gopherbot gopherbot closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conspicuousClockwork @gopherbot @googlebot