text/html: MIME type "application/ld+json: should be escaped as JS #26054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

eklitzke wants to merge 1 commit into golang:master from eklitzke:jsonld

Contributor

eklitzke commented Jun 25, 2018

Teach the text/html package to understand the "application/ld+json" MIME
type (used for JSON-LD data) as JS, so it can be apply the correct contextual
escaping.

Fixes #26053


          text/html: MIME type "application/ld+json: should be escaped as JS

5a3eea3

Teach the text/html package to understand the "application/ld+json" MIME
type (used for JSON-LD data) as JS, so it can be apply the correct contextual
escaping.

Fixes golang#26053

googlebot added the cla: yes label

Contributor

gopherbot commented Jun 25, 2018

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 27, 2018

Message from Mike Samuel:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

gopherbot force-pushed the master branch 12 times, most recently from 4016de0 to d2f663c Compare

July 18, 2018 19:56

gopherbot force-pushed the master branch 9 times, most recently from 9092511 to 95c3348 Compare

July 19, 2018 18:17

gopherbot force-pushed the master branch 4 times, most recently from 0090c13 to 8fbbf63 Compare

July 28, 2018 01:16

Contributor

gopherbot commented Nov 15, 2018

Message from Emmanuel Odeke:

Patch Set 1: Run-TryBot+1 Code-Review+2

Thank you for working on this Evan and for the security nod, Mike!

On the issue seems like Filippo gave a LGTM but I'll also loop him in
for the official +2 here

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 15, 2018

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=b46bfeed

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 15, 2018

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on openbsd-amd64-64:
See https://storage.googleapis.com/go-build-log/b46bfeed/openbsd-amd64-64_5be44bb1.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 15, 2018

Message from Emmanuel Odeke:

Patch Set 1:

Patch Set 1:

Build is still in progress...
This change failed on openbsd-amd64-64:
See https://storage.googleapis.com/go-build-log/b46bfeed/openbsd-amd64-64_5be44bb1.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

The trybot failure is unrelated to this change

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 15, 2018

Message from Emmanuel Odeke:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 15, 2018

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

1 of 19 TryBots failed:
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/b46bfeed/openbsd-amd64-64_5be44bb1.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 15, 2018

Message from Emmanuel Odeke:

Patch Set 1: Run-TryBot+1

RELNOTE=yes

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 15, 2018

Message from Agniva De Sarker:

Patch Set 1:

Emmanuel/Filippo - this is not merged yet. Since this has been posted and +2'd some time back, I think this is safe enough to go to 1.12.

Anything blocking this ?

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 15, 2018

Message from Emmanuel Odeke:

Patch Set 1:

Patch Set 1:

Emmanuel/Filippo - this is not merged yet. Since this has been posted and +2'd some time back, I think this is safe enough to go to 1.12.

Anything blocking this ?

Agniva, in deed. I think it is safe to go through and am just waiting for Filippo to send his final blessing that he posted on the issue.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 15, 2018

Message from Filippo Valsorda:

Patch Set 1:

(1 comment)

LGTM with a nit about the commit message.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

agnivade commented Nov 19, 2018

@eklitzke - Wanted to ping you here since I did not see you copied in the gerrit CL. Would you be able to take a look at Filippo's comments ? Thanks !

bradfitz force-pushed the master branch from c9b4dca to 8c5c2b7 Compare

November 21, 2018 19:23

Contributor

gopherbot commented Dec 13, 2018

Message from Ian Lance Taylor:

Patch Set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 13, 2018

This PR is being closed because golang.org/cl/120835 has been merged.

gopherbot closed this

gopherbot pushed a commit that referenced this pull request


          text/html: escape MIME type "application/ld+json" as JavaScript

784d810

Fixes #26053

Change-Id: Ic2052b1d0d4e0826a217a520c83d7bb0995ea72a
GitHub-Last-Rev: 5a3eea3
GitHub-Pull-Request: #26054
Reviewed-on: https://go-review.googlesource.com/c/120835
Reviewed-by: Emmanuel Odeke <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels