Skip to content

cmd/asm: allow methods implemented in assembly #25274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

cmd/asm: allow methods implemented in assembly #25274

wants to merge 1 commit into from

Conversation

chai2010
Copy link
Contributor

@chai2010 chai2010 commented May 6, 2018

  1. allow methods implemented in assembly, identifier name support "main.(*SomeType).method" format
  2. if the symbol starts with type··x, rewrite it as type·""·x

fixes #4978

@chai2010
cmd/asm: allow methods implemented in assembly
8d52a6e 
1. allow methods implemented in assembly, identifier name support "main.(*SomeType).method" format
2. if the symbol starts with type··x, rewrite it as type·""·x

fixes #4978
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 6, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: 8d52a6e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/111648 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

This would need tests, but more importantly it would also need a decision about whether we're going to do this.

Making it work is not the difficult part; Russ sent out a change to make it work some time ago privately to another user. AFAIK, this is in the "Thinking" status on GitHub because people aren't sure whether it's a good idea.

But I'll flag it for a decision for Go 1.12. (too late for Go 1.11 per https://github.com/golang/go/wiki/Go-Release-Cycle)

Please don’t reply on this GitHub thread. Visit golang.org/cl/111648.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 2 times, most recently from e4259d6 to 6dbaf03 Compare May 31, 2018 18:23
@gopherbot gopherbot force-pushed the master branch 20 times, most recently from 9092511 to 95c3348 Compare July 19, 2018 18:17
@gopherbot gopherbot force-pushed the master branch 4 times, most recently from 0090c13 to 8fbbf63 Compare July 28, 2018 01:16
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/111648 has been abandoned.

Decision is not to do it. See github issue.

@gopherbot gopherbot closed this Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd/compile: allow methods implemented in assembly
3 participants
@chai2010 @gopherbot @googlebot