-
Notifications
You must be signed in to change notification settings - Fork 18.1k
cmd/go: fix formatting of file paths under cwd #23985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The output of go with -x flag is formatted in a manner that file paths under current directory are modified to start with a dot (.), but when the directory path ends with a slash (/), the formatting goes wrong. Fixes 23982.
This PR (HEAD: 3c3f1cf) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/95755 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 1: (3 comments) Thanks. This should probably have a small test in cmd/go/go_test.go. Please don’t reply on this GitHub thread. Visit golang.org/cl/95755. |
This PR (HEAD: 1493f38) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/95755 to see it. Tip: You can toggle comments from me using the |
Message from Hironao OTSUBO: Patch Set 2: (3 comments)
Thanks. Added one test. Please don’t reply on this GitHub thread. Visit golang.org/cl/95755. |
Message from Gerrit Bot: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/95755. |
Message from Ian Lance Taylor: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/95755. |
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=7378fc1e Please don’t reply on this GitHub thread. Visit golang.org/cl/95755. |
Message from Gobot Gobot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/95755. |
The output of go with -x flag is formatted in a manner that file paths under current directory are modified to start with a dot (.), but when the directory path ends with a slash (/), the formatting goes wrong. Fixes #23982 Change-Id: I8f8d15dd52bee882a9c6357eb9eabdc3eaa887c3 GitHub-Last-Rev: 1493f38 GitHub-Pull-Request: #23985 Reviewed-on: https://go-review.googlesource.com/95755 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Message from Ian Lance Taylor: Patch Set 3: Code-Review+2 Thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/95755. |
This PR is being closed because golang.org/cl/95755 has been merged. |
The output of go with -x flag is formatted in a manner that file paths
under current directory are modified to start with a dot (.), but when
the directory path ends with a slash (/), the formatting goes wrong.
Fixes #23982