Skip to content

doc: minor wording improvement to the diagnostics guide #23754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: minor wording improvement to the diagnostics guide #23754

wants to merge 1 commit into from

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Feb 9, 2018

No description provided.

@rakyll
doc: minor wording improvement to the diagnostics guide
6d2cfcc 
Change-Id: I7ca964a8bce1f7a990c25f61035ffbecb8548fcd
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 9, 2018
@rakyll rakyll requested a review from andybons February 9, 2018 01:14
@gopherbot
Copy link
Contributor

This PR (HEAD: 6d2cfcc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/92996 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@rakyll rakyll removed the request for review from andybons February 9, 2018 01:16
@gopherbot
Copy link
Contributor

Andrew Bonventre has posted review comments at golang.org/cl/92996.

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/92996 has been merged.

@gopherbot gopherbot closed this Feb 9, 2018
gopherbot pushed a commit that referenced this pull request Feb 9, 2018
@rakyll
doc: minor wording improvement to the diagnostics guide
ee59f6d 
Change-Id: I8469fbbb934f096f04ad68c592aacdb805b6d2d4
GitHub-Last-Rev: 6d2cfcc
GitHub-Pull-Request: #23754
Reviewed-on: https://go-review.googlesource.com/92996
Reviewed-by: Andrew Bonventre <[email protected]>
@rakyll rakyll deleted the update branch February 9, 2018 01:24
@bradfitz
Copy link
Contributor

bradfitz commented Feb 9, 2018

Btw, the Go 1.10 tree is still frozen, but this was kinda special, as we are testing GerritBot and this is a safe change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rakyll @gopherbot @bradfitz @googlebot