Skip to content

runtime: disable crash on invalid pointer? #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rsc opened this issue Oct 3, 2014 · 3 comments
Closed

runtime: disable crash on invalid pointer? #8861

rsc opened this issue Oct 3, 2014 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@rsc
Copy link
Contributor

rsc commented Oct 3, 2014 

CL 148470043 will introduce code that causes the runtime to crash if the garbage
collector sees an invalid pointer. Because we believe that everything is precise, a
crash in this code indicates a bug: either the collector has freed something it should
not have, or something that looks like a pointer is being scanned conservatively, or
something is creating invalid pointers.

This should help shake out latent bugs in the runtime during the release freeze.

It is not yet clear to me whether we should keep this code in the actual release. This
issue is to decide between:

1) Leave crash.
2) Make crash on-by-default but disabled by a GODEBUG setting.
3) Remove crash, ignoring invalid pointer.

We can make the decision based on how much we see the crashes.
@gopherbot
Copy link
Contributor

Comment 1:

CL https://golang.org/cl/148470043 mentions this issue.

@gopherbot
Copy link
Contributor

Comment 2:

CL https://golang.org/cl/165780043 mentions this issue.

@rsc
Copy link
Contributor Author

rsc commented Oct 29, 2014

Comment 3:

This issue was closed by revision 8fcdc70.

Status changed to Fixed.

@rsc rsc added fixed labels Oct 29, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@rsc @wheatman
runtime: add GODEBUG invalidptr setting
8c27348 
Fixes golang#8861.
Fixes golang#8911.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/165780043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@rsc @wheatman
runtime: add GODEBUG invalidptr setting
05cdac0 
Fixes golang#8861.
Fixes golang#8911.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/165780043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@rsc @wheatman
runtime: add GODEBUG invalidptr setting
a728162 
Fixes golang#8861.
Fixes golang#8911.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/165780043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018
@rsc @wheatman
runtime: add GODEBUG invalidptr setting
e4cd8e6 
Fixes golang#8861.
Fixes golang#8911.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/165780043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@rsc @wheatman
runtime: add GODEBUG invalidptr setting
3f3331a 
Fixes golang#8861.
Fixes golang#8911.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/165780043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
2 participants
@rsc @gopherbot