-
Notifications
You must be signed in to change notification settings - Fork 18.1k
x/benchmarks: cockroachdb failing after CL 564197 (runtime: only poll network from one P at a time in findRunnable) #73474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Change https://go.dev/cl/667336 mentions this issue: |
This reverts commit 352dd2d. Reason for revert: cockroachdb benchmark failing. Likely due to CL 564197. For #73474 Change-Id: Id5d83cd8bb8fe9ee7fddb8dc01f1a01f2d40154e Reviewed-on: https://go-review.googlesource.com/c/go/+/667336 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: Mauri de Souza Meneguzzo <[email protected]> Auto-Submit: Carlos Amedee <[email protected]>
Change https://go.dev/cl/668735 mentions this issue: |
This change updates the version of Cockroachdb benchmarked by sweet. When we submitted a change to how the network is polled in CL 564197 we discovered that older versions of Cockroachdb modify the scheduler in a way that is incompatable with the submitted change. This updates the version of Cockroachdb to a version where that incompatibility no longer exists. For golang/go#73474 For golang/go#65064 Change-Id: Ifae845e025a5b64ff2cfff65e8c508c999ffbcb4 Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/668735 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Pratt <[email protected]>
Change https://go.dev/cl/670416 mentions this issue: |
While we were working to address Issue #65064, we submitted CL 564197. Once that CL was submitted, the perf builders began failing. The failures were due to CockroachDB benchmark failures. The failures were timeouts in the tests. The failures were due to CockroachDB using a internal copy/clone of schedt which became out of sync with the Go runtime. CockroachDB has transitioned from using an internal copy/clone of schedt. When we run the benchmark against the tip version of CockroachDB it fails because of a another issue cockroachdb/cockroach#124021. We should update the version that we test against and attempt to exclude the failing benchmark |
Following up on the previous message. We should update the version that we test against and attempt to mitigate the effects of the root cause of the error condition found in cockroachdb/cockroach#124021. I will mail a CL updating the version of CockroachDB we benchmark against and then send a follow-up CL which retries failing benchmarks. The error we are experiencing i logged as:
|
As of https://go.dev/cl/564197 (for #65064), all 4 perf builders are failing due to cockroachdb errors.
e.g., https://ci.chromium.org/ui/p/golang/builders/ci/gotip-linux-arm64_c4ah72-perf_vs_release/b8716897839307984241/overview
At the moment, this CL is the most recent run of these builders, so more data will be useful to see if this is consistent. But given that all builders failed, it seems less likely to be a flake.
The text was updated successfully, but these errors were encountered: