Skip to content

cmd/compile: syscall.Syscall15: nosplit stack over 792 byte limit [1.23 backport] #69848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Oct 11, 2024 · 2 comments
Closed

cmd/compile: syscall.Syscall15: nosplit stack over 792 byte limit [1.23 backport] #69848

gopherbot opened this issue Oct 11, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.23.3

Comments

@gopherbot
Copy link
Contributor

@qmuntal requested issue #69813 to be considered for backport to the next 1.23 minor release.

@gopherbot Please backport to 1.23. This is a regression with no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 11, 2024
@gopherbot gopherbot mentioned this issue Oct 11, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 11, 2024
@gopherbot gopherbot added this to the Go1.23.3 milestone Oct 11, 2024
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Oct 23, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 23, 2024
@Snshadow Snshadow mentioned this issue Oct 29, 2024
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/623516 mentions this issue: [release-branch.go1.23] runtime: reduce syscall.SyscallX stack usage

gopherbot pushed a commit that referenced this issue Oct 30, 2024
@qmuntal @prattmic
[release-branch.go1.23] runtime: reduce syscall.SyscallX stack usage
1207de4 
syscall.SyscallX consumes a lot of stack space, which is a problem
because they are nosplit functions. They used to use less stack space,
but CL 563315, that landed in Go 1.23, increased the stack usage by a
lot.

This CL reduces the stack usage back to the previous level.

Fixes #69848
Updates #69813

Change-Id: Iddedd28b693c66a258da687389768055c493fc2e
Reviewed-on: https://go-review.googlesource.com/c/go/+/618497
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
(cherry picked from commit fa7343a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/623516
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 623516 (commit 1207de4) to release-branch.go1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.23.3
Development

No branches or pull requests
2 participants
@prattmic @gopherbot