Skip to content

x/tools/gopls: remove the "allowModfileModifications" setting #65546

Closed
@findleyr

Description

@findleyr

Following up on #56570, we should remove the deprecated allowModFileModifications setting.

Quoting: #56570 (comment):

Generally speaking, this setting means "whatever the go command does to your go.mod file is OK". That's not a coherent mode of operation for gopls to support, which is why it has no test coverage. Additionally, the documentation says "this option will eventually be removed".

We should surface the deprecation notice in [email protected], and remove in [email protected].

I don't think this setting works well, so I don't see how it could be useful to any users. However, if you need this setting, please explain why!

Metadata

Metadata

Assignees

No one assigned

    Labels

    ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions