Skip to content

x/telemetry: make counter, upload operations no-op on platforms not covered in testing #65448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hyangah opened this issue Feb 2, 2024 · 1 comment
Closed

x/telemetry: make counter, upload operations no-op on platforms not covered in testing #65448

hyangah opened this issue Feb 2, 2024 · 1 comment
Assignees
@matloob
Labels
FrozenDueToAge telemetry x/telemetry issues
Milestone
Unreleased

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 2, 2024

See GOOS/GOARCH excluded from telemetry library's testing.

https://go.googlesource.com/telemetry/+/refs/heads/master/internal/testenv/testenv.go#58

Related #65447
@gopherbot gopherbot added the telemetry x/telemetry issues label Feb 2, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 2, 2024
@matloob
Copy link
Contributor

matloob commented Feb 5, 2024 •
edited
Loading

This should be fixed by golang.org/cl/560462

@matloob matloob closed this as completed Feb 5, 2024
@golang golang locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matloob matloob

Labels
FrozenDueToAge telemetry x/telemetry issues
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @matloob