x/build/env/wasip1-wasm-wazero: wasip1 tests are failing

[johanbrandhorst]

#!watchflakes
post <- pkg == "test" && test == "Test" && date >= "2023-07-12" && builder ~ `wazero` && log ~ `tmp__.go:\d+:\d+: syntax error:`

After enabling nonblocking io on stdin, stdout and stderr in CL 498196, the wazero wasip1 runner started to fail. The errors look like this:

##### ../test
--- FAIL: Test (0.07s)
    --- FAIL: Test/fixedbugs/bug449.go (0.94s)
        testdir_test.go:141: exit status 1
            # command-line-arguments
            ../../tmp/Testfixedbugsbug449.go4132839843/001/tmp__.go:3072:6: syntax error: unexpected package, expected name
            ../../tmp/Testfixedbugsbug449.go4132839843/001/tmp__.go:3866:53: syntax error: unexpected main at end of statement
            ../../tmp/Testfixedbugsbug449.go4132839843/001/tmp__.go:3870:6: syntax error: unexpected call, expected (
            ../../tmp/Testfixedbugsbug449.go4132839843/001/tmp__.go:4660:53: syntax error: unexpected main at end of statement
            ../../tmp/Testfixedbugsbug449.go4132839843/001/tmp__.go:4664:6: syntax error: unexpected call, expected (
            ../../tmp/Testfixedbugsbug449.go4132839843/001/tmp__.go:6214:13: syntax error: unexpected package, expected expression
            ../../tmp/Testfixedbugsbug449.go4132839843/001/tmp__.go:6216:1: syntax error: unexpected var at end of statement
            ../../tmp/Testfixedbugsbug449.go4132839843/001/tmp__.go:6218:6: syntax error: unexpected call, expected (
            ../../tmp/Testfixedbugsbug449.go4132839843/001/tmp__.go:9285:6: syntax error: unexpected package, expected name
            

Sample error log.

The link to the standard I/O change seems pretty clear, but the cause is likely a runtime bug. An issue has been filed with the wazero runtime project. The fix will likely be an update to the wazero version used in the builders.

The wasmtime runner continues to pass all tests as expected.

[gopherbot]

Change https://go.dev/cl/506695 mentions this issue: dashboard: add wazero known issue

[johanbrandhorst]

The wazero issue has been closed and will be available in the next release. We'll upgrade the Wazero runner and hopefully close this issue then.

[johanbrandhorst]

The tests pass locally for me with the new wazero version

[gopherbot]

Change https://go.dev/cl/508875 mentions this issue: env: upgrade wazero version

[johanbrandhorst]

It seems this isn't quite fixed yet in Wazero v1.3.0, I've posted an update to the original issue.

[gopherbot]

Change https://go.dev/cl/512255 mentions this issue: env: upgrade wazero version