Skip to content

cmd/compile: incorrect inline function variable [1.20 backport] #59580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 12, 2023 · 2 comments
Closed

cmd/compile: incorrect inline function variable [1.20 backport] #59580

gopherbot opened this issue Apr 12, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.20.4

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #59572 to be considered for backport to the next 1.20 minor release.

@gopherbot please open backport issues. This is a bad miscompilation.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 12, 2023
@gopherbot gopherbot mentioned this issue Apr 12, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 12, 2023
@gopherbot gopherbot added this to the Go1.20.4 milestone Apr 12, 2023
@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Apr 12, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 12, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/484136 mentions this issue: [release-branch.go1.20] cmd/compile: fix ir.StaticValue for ORANGE

gopherbot pushed a commit that referenced this issue Apr 12, 2023
@wdvxdr1123 @mdempsky
[release-branch.go1.20] cmd/compile: fix ir.StaticValue for ORANGE
1dbbac7 
Range statement will mutate the key and value, so we should treat them as reassigned.

Fixes #59580

Change-Id: I9c6b67d938760a0c6a1d9739f2737c67af4a3a10
Reviewed-on: https://go-review.googlesource.com/c/go/+/483855
Run-TryBot: Wayne Zuo <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Auto-Submit: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
(cherry picked from commit 89567a3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/484136
Run-TryBot: Matthew Dempsky <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 1dbbac7 to release-branch.go1.20.

bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@wdvxdr1123 @bradfitz
[release-branch.go1.20] cmd/compile: fix ir.StaticValue for ORANGE
5c2bf92 
Range statement will mutate the key and value, so we should treat them as reassigned.

Fixes golang#59580

Change-Id: I9c6b67d938760a0c6a1d9739f2737c67af4a3a10
Reviewed-on: https://go-review.googlesource.com/c/go/+/483855
Run-TryBot: Wayne Zuo <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Auto-Submit: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
(cherry picked from commit 89567a3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/484136
Run-TryBot: Matthew Dempsky <[email protected]>
bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@wdvxdr1123 @bradfitz
[release-branch.go1.20] cmd/compile: fix ir.StaticValue for ORANGE
e10b814 
Range statement will mutate the key and value, so we should treat them as reassigned.

Fixes golang#59580

Change-Id: I9c6b67d938760a0c6a1d9739f2737c67af4a3a10
Reviewed-on: https://go-review.googlesource.com/c/go/+/483855
Run-TryBot: Wayne Zuo <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Auto-Submit: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
(cherry picked from commit 89567a3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/484136
Run-TryBot: Matthew Dempsky <[email protected]>
@golang golang locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.20.4
Development

No branches or pull requests
2 participants
@dr2chase @gopherbot