Skip to content

cmd/internal/obj/x86: fix POPCNT instruction #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 15, 2013 · 12 comments
Closed

cmd/internal/obj/x86: fix POPCNT instruction #4816

gopherbot opened this issue Feb 15, 2013 · 12 comments
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@gopherbot
Copy link
Contributor

by rayneolivetti:

Before filing a bug, please check whether it has been fixed since the
latest release. Search the issue tracker and check that you're running the
latest version of Go:

Run "go version" and compare against
http://golang.org/doc/devel/release.html  If a newer version of Go exists,
install it and retry what you did to reproduce the problem.

Thanks.

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. Try feeding a popcnt instruction to 6a
2.
3.

What is the expected output?


What do you see instead?
Unknown instruction error

Which compiler are you using (5g, 6g, 8g, gccgo)?
6a

Which operating system are you using?
Arch Linux

Which version are you using?  (run 'go version')
go version go1.0.3

Please provide any additional information below.
@minux
Copy link
Member

minux commented Feb 15, 2013

Comment 1:

feel free to propose CL for this (an example is:
http://golang.org/cl/5970055)
for now, you could use something like this:
#define POPCNT_AX_AX BYTE $0xf3; BYTE $0x48; BYTE $0x0f; BYTE $0xb8; BYTE $0xc0

Labels changed: added priority-someday, removed priority-triage, go1.1maybe.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 2:

Labels changed: added go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 3:

Labels changed: added feature.

@robpike
Copy link
Contributor

robpike commented Aug 16, 2013

Comment 4:

Labels changed: added go1.3maybe, removed go1.2maybe.

@robpike
Copy link
Contributor

robpike commented Aug 20, 2013

Comment 5:

Labels changed: removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 6:

Labels changed: added repo-main.

@robpike
Copy link
Contributor

robpike commented Feb 26, 2014

Comment 7:

Issue #7357 has been merged into this issue.

@rsc
Copy link
Contributor

rsc commented Mar 3, 2014

Comment 8:

Adding Release=None to all Priority=Someday bugs.

Labels changed: added release-none.

@robpike robpike mentioned this issue Dec 8, 2014
Closed
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@brtzsnr brtzsnr mentioned this issue May 8, 2015
Closed
@rsc rsc changed the title cmd/6a, cmd/6l: add popcnt instruction cmd/internal/obj/amd64: add popcnt instruction Jun 8, 2015
@minux minux changed the title cmd/internal/obj/amd64: add popcnt instruction cmd/internal/obj/x86: add popcnt instruction Jan 7, 2016
@rsc
Copy link
Contributor

rsc commented Jan 22, 2016

POPCNT has been added but was done without a suffix.
Repurposing this bug for fixing the suffix.
Then it will be completed.

@rsc rsc changed the title cmd/internal/obj/x86: add popcnt instruction cmd/internal/obj/x86: fix POPCNT instruction Jan 22, 2016
@rsc rsc modified the milestones: Go1.6, Unplanned Jan 22, 2016
@gopherbot
Copy link
Contributor Author

CL https://golang.org/cl/18850 mentions this issue.

@gopherbot
Copy link
Contributor Author

CL https://golang.org/cl/18851 mentions this issue.

@gopherbot
Copy link
Contributor Author

CL https://golang.org/cl/18848 mentions this issue.

gopherbot pushed a commit that referenced this issue Jan 24, 2016
@rsc
cmd/internal/obj/x86: rename POPCNT to POPCNTQ
f844b0b 
Ilya added POPCNT in a CL earlier this month but it's really only POPCNTQ.
The other forms still need to be added.

For #4816.

Change-Id: I1186850d32ad6d5777475c7808e6fc9d9133e118
Reviewed-on: https://go-review.googlesource.com/18848
Reviewed-by: Rob Pike <[email protected]>
gopherbot pushed a commit that referenced this issue Jan 24, 2016
@rsc
cmd/asm: add generated test of amd64 instruction encodings
659c632 
Generated by x86test, from https://golang.org/cl/18842
(still in progress).

The commented out lines are either missing or misspelled
or incorrectly handled instructions.

For #4816, #8037, #13822, #14068, #14069.

Change-Id: If309310c97d9d2a3c71fc64c51d4a957e9076ab7
Reviewed-on: https://go-review.googlesource.com/18850
Reviewed-by: Rob Pike <[email protected]>
Run-TryBot: Russ Cox <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@golang golang locked and limited conversation to collaborators Jan 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
4 participants
@rsc @minux @robpike @gopherbot