Skip to content

x/tools/gopls: IWL progress report canceled and not marked as done #46930

Closed
@stamblerre

Description

@stamblerre

In a test failure on https://golang.org/cl/330969, we got this log: https://storage.googleapis.com/go-build-log/37f9a8f6/linux-amd64-race_7069ae28.log.

Here are the relevant logs:

[Trace - 16:39:22.158 PM] Received request 'window/workDoneProgress/create - (14)'.
Params: {"token":"2673644565579601470"}


[Trace - 16:39:22.161 PM] Sending response 'window/workDoneProgress/create - (14)' in 3ms.
Result: 


[Trace - 16:39:22.163 PM] Received notification '$/cancelRequest'.
Params: {"id":14}

The token 2673644565579601470 never gets a Done. progress report, and it's listed as outstanding work when the test fails:

#### End Gopls Test Logs for "TestProgressBarErrors/singleton"
--- FAIL: TestProgressBarErrors (20.41s)
    --- FAIL: TestProgressBarErrors/singleton (20.00s)
        diagnostics_test.go:1539: waiting on:
            	Unmet: no outstanding work
            
            err:context deadline exceeded
            
            state:
            #### log messages (see RPC logs for full text):
            	Error: "2021/06/25 16:39:21 copying workspace dir: /workd...
            	Info: "2021/06/25 16:39:21 go env for /workdir/tmp/gopls-...
            	Error: "2021/06/25 16:39:21 errors loading workspace: /wo...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 errors loading workspace: /wo...
            	Info: "2021/06/25 16:39:22 go/packages.Load\n\tsnapshot=5...
            	Info: "2021/06/25 16:39:22 go/packages.Load\n\tsnapshot=7...
            
            #### diagnostics:
            	go.mod (version 3):
            
            #### outstanding work:
            	!NO NAME(token: 2673644565579601470): 0.00
            #### completed work:
            	Error loading workspace: 1
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1
            	diagnosing opened files: 1
            	diagnosing changed files: 2
            	diagnosing saved files: 2
            	diagnosing files changed on disk: 2
            	Load: 2
        runner.go:310: Shutdown: context deadline exceeded
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/diagnostics	269.024s
ok  	golang.org/x/tools/gopls/internal/regtest/misc	226.881s
ok  	golang.org/x/tools/gopls/internal/regtest/modfile	44.929s
ok  	golang.org/x/tools/gopls/internal/regtest/watch	52.971s
ok  	golang.org/x/tools/gopls/internal/regtest/workspace	86.820s
?   	golang.org/x/tools/gopls/release	[no test files]
ok  	golang.org/x/tools/gopls/test	115.662s
ok  	golang.org/x/tools/gopls/test/debug	24.212s
FAIL

/cc @findleyr

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.TestingAn issue that has been verified to require only test changes, not just a test failure.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.okay-after-beta1Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions