x/tools/go/analysis/passes/nilness: not report slice as non-nil

[komem3]

What version of Go are you using (go version)?

$ go version
go version go1.16 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

linux amd64

go env Output

$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOVCS=""
GOVERSION="go1.16"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1084334382=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I checked the following code by nilness

	f := make([]string, 0)
	if f == nil {
		log.Printf("nil")
	}

What did you expect to see?

I expected to detect comparison of non-nil and nil

What did you see instead?

not detect

[gopherbot]

Change https://golang.org/cl/303890 mentions this issue: go/analysis/passes/nilness: fixed slice not being considered as non-nil

[cagedmantis]

/cc @matloob

[timothy-king]

/cc @guodongli-google