Skip to content

runtime/debug: TestPanicOnFault consistently failing on netbsd-arm-bsiegert #45026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bcmills opened this issue Mar 15, 2021 · 7 comments
Open
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-NetBSD
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 15, 2021

@bcmills bcmills added OS-NetBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-arm Issues solely affecting the 32-bit arm architecture. labels Mar 15, 2021
@bcmills bcmills added this to the Backlog milestone Mar 15, 2021
@bsiegert
Copy link
Contributor

I meant to write about this, you beat me to it :)

While the builder was offline, I updated it to the latest NetBSD-current (9.99.80), which is when this failure started appearing. (Before that, it was running 8.99.24, from 2018.)

I'll try to see if it is reproducible with the latest stable release (9.1).

@bsiegert
Copy link
Contributor

The builder is running NetBSD-9.1 now. Unfortunately, the error message is still the same: https://build.golang.org/log/4978e756d9fde52031a84fb8c0dd112f535cf01a

@randall77
Copy link
Contributor

Try writing a C program that faults, and grab the faulting address in the C signal handler. See if you can make that work.

@thanm
Copy link
Contributor

thanm commented Jul 19, 2021

@bsiegert this same problem has been happening for a couple of months now. Any update? Seems that this builder is not really providing a good "signal" if it has been failing for so long. It is not really a good use of developer's time to have to check each CL to make sure that it's just the same "known" failure as opposed to something new.

@bsiegert
Copy link
Contributor

Sorry for the lack of updates.

I looked into this just yesterday -- what is happening is that we do not get the fault address from the kernel any more, even though SetPanicOnFault has been called. However, I could not find a reason why that would be the case. I suspect a regression in the OS, since it started happening after a kernel update.

I would like to send a CL to skip the test for now, so that the builder can once again provide meaningful signal. Would that be okay?

@thanm
Copy link
Contributor

thanm commented Jul 20, 2021

SGTM

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/335909 mentions this issue: runtime/debug: skip TestPanicOnFault on netbsd/arm

gopherbot pushed a commit that referenced this issue Jul 20, 2021
This test has been failing since the builder was updated to
NetBSD 9. While the issue is under investigation, skip the test
so that we do not miss other breakage.

Update issue #45026

Change-Id: Id083901c517f3f88e6b4bc2b51208f65170d47a6
Reviewed-on: https://go-review.googlesource.com/c/go/+/335909
Reviewed-by: Than McIntosh <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Trust: Benny Siegert <[email protected]>
Run-TryBot: Benny Siegert <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-NetBSD
Projects
None yet
Development

No branches or pull requests

5 participants