go/types, types2: writeType does not invoke Qualifier when printing an unsafe.Pointer

[cixel]

Because unsafe.Pointer is a *types.Basic, the type stringifier uses a special case to print the package name:

case *Basic:
	if t.kind == UnsafePointer {
		buf.WriteString("unsafe.")
	}

As written, this does not allow a given Qualifier function to run and control how the package name is printed, which means that anything which wants to print something other than "unsafe" must do so by also special casing unsafe.Pointer.

Is there any reason not to use the Qualifier function in writeType when printing unsafe.Pointer? This would be a very quick change, but I wanted to make sure the current functionality isn't deliberate before opening a CL.

[findleyr]

This seems reasonable to me. Given that this logic predates https://golang.org/cl/11692 adding the Qualifier function, perhaps this was just an oversight.

CC @griesemer

[gopherbot]

Change https://golang.org/cl/295271 mentions this issue: cmd/compile/internal/types2: use regular type printing for unsafe.Pointer

[griesemer]

Thanks for pointing this out; I think @findleyr is correct, this looks like an oversight. Fix is out.

[gopherbot]

Change https://golang.org/cl/296289 mentions this issue: cmd/guru: update golden file (fix test failure)