Skip to content

x/pkgsite: support viewing the standard library @master #44390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julieqiu opened this issue Feb 18, 2021 · 4 comments
Closed

x/pkgsite: support viewing the standard library @master #44390

julieqiu opened this issue Feb 18, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/golang.or...

Comments

@julieqiu
Copy link
Member

It would be useful to view https://pkg.go.dev/std@master. This issue was originally opened in #39973.

At the moment, when running the worker and visiting http://localhost:8000/fetch/std/@v/master, this error shows up in the version_map table:

fetchAndInsertModule("std", "master"): FetchModule("std", "master"): processZipFile("std", "v0.0.0-20210218181204-f3c2208e2cca"): extractPackagesFromZip(ctx, "std", "v0.0.0-20210218181204-f3c2208e2cca", r, d): expected file to have prefix "[email protected]/"; got = "std@master/AUTHORS": module zip is malformed: bad module

@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 18, 2021
@gopherbot gopherbot added this to the Unreleased milestone Feb 18, 2021
@julieqiu julieqiu self-assigned this Feb 18, 2021
@slrz slrz mentioned this issue Feb 18, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/294831 mentions this issue: internal/stdlib: fix Zip for master version

gopherbot pushed a commit to golang/pkgsite that referenced this issue Feb 22, 2021
@julieqiu
internal/stdlib: fix Zip for master version
f15a2b1 
An error is fixed when creating the zipfile for std@master, which
prevented the module from being fetched. A test is also added.

For golang/go#44390

Change-Id: I279146aef10311822f47f16259a2223c879140c2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/294831
Trust: Julie Qiu <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/294350 mentions this issue: internal/postgres,worker: schedule fetching of std@master

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/294832 mentions this issue: internal/frontend: enable requests to std@master

gopherbot pushed a commit to golang/pkgsite that referenced this issue Feb 22, 2021
@julieqiu
internal/postgres,worker: schedule fetching of std@master
63629dc 
In order to ensure that pkg.go.dev/std@master is always showing the
latest version, an endpoint is added which checks for the most recent
version of std@master. If the version in our database is not up to date,
a fetch request is scheduled.

Additionally, since only the most recent pseudoversion of std is ever
shown on pkg.go.dev, older versions are deleted.

For golang/go#44390

Change-Id: Iad56b8653f378fb5a7d72a1e30505da090de279d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/294350
Trust: Julie Qiu <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
gopherbot pushed a commit to golang/pkgsite that referenced this issue Feb 23, 2021
@julieqiu
internal/frontend: enable requests to std@master
bc0218a 
Requests to pkg.go.dev/std@master are now supported.

For golang/go#44390

Change-Id: Ie64ea679bfe855aa690004bf6effd7be424aa5dc
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/294832
Trust: Julie Qiu <[email protected]>
Reviewed-by: Jamal Carvalho <[email protected]>
@julieqiu
Copy link
Member Author

Requests to https://pkg.go.dev/std@master are now supported.

@golang golang locked and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/golang.org-features
Development

No branches or pull requests
2 participants
@julieqiu @gopherbot