Skip to content

doc: Broken image in readme #44295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobrik opened this issue Feb 16, 2021 · 4 comments
Closed

doc: Broken image in readme #44295

bobrik opened this issue Feb 16, 2021 · 4 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@bobrik
Copy link

bobrik commented Feb 16, 2021

The issue

Commit 0cb3415 by @rsc removed doc/gopher/fiveyears.jpg, which is referenced in README.md.

What did you expect to see?

image

What did you see instead?

image
@seankhliao seankhliao changed the title Broken image in readme doc: Broken image in readme Feb 16, 2021
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Feb 16, 2021
@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 16, 2021
@dmitshur dmitshur added this to the Go1.16 milestone Feb 16, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/292629 mentions this issue: README: pull gopher image from website

@dmitshur
Copy link
Member

@gopherbot Please backport this to Go 1.16. It is a safe documentation fix needed to restore the gopher image at https://pkg.go.dev/std#section-readme (and any other place that displays the README of the Go standard library at release tags).

@gopherbot
Copy link
Contributor

Backport issue(s) opened: #44402 (for 1.16).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@gopherbot gopherbot mentioned this issue Feb 19, 2021
Closed
@dmitshur dmitshur modified the milestones: Go1.16, Go1.17 Feb 19, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/293843 mentions this issue: [release-branch.go1.16] README: pull gopher image from website

gopherbot pushed a commit that referenced this issue Feb 25, 2021
@ianlancetaylor @dmitshur
[release-branch.go1.16] README: pull gopher image from website
0b8c416 
Fixes breakage accidentally introduced by https://golang.org/cl/291711.

Fixes #44402.
Updates #44295.

Change-Id: I76f3e5577d1d24027d4ed2a725b5b749ab2d059c
Reviewed-on: https://go-review.googlesource.com/c/go/+/292629
Trust: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
(cherry picked from commit 6f3da9d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/293843
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
@golang golang locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@bobrik @dmitshur @gopherbot @seankhliao