x/tools/gopls: invalid memory address or nil pointer dereference in internal/lsp/source.HoverIdentifier

[dazoe]

gopls version: v0.6.5
gopls flags:
extension version: 0.22.0
environment: Code - OSS

ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.

Describe what you observed.

changed "ui.navigation.importShortcut" to "Link", then tried to ctrl click on import statement.
seem the crash can also be triggered just by hovering over the import statement as well

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x7bc3f2]

goroutine 3816 [running]:
golang.org/x/tools/internal/lsp/source.HoverIdentifier(0xef7cb8, 0xc00318e570, 0x0, 0x0, 0x0, 0x0)
	  hover.go:93  0xd2
golang.org/x/tools/internal/lsp/source.Hover(0xef7cb8, 0xc0059d23c0, 0xf09000, 0xc0003562a0, 0xefb798, 0xc0011610e0, 0x4020000000000000, 0x4042800000000000, 0xf00838, 0xc0011610e0, ...)
	  hover.go:64  0xdb
golang.org/x/tools/internal/lsp.(*Server).hover(0xc00017c2a0, 0xef7cb8, 0xc0059d23c0, 0xc00318e030, 0x0, 0x0, 0x0)
	  hover.go:25  0x2ce
golang.org/x/tools/internal/lsp.(*Server).Hover(0xc00017c2a0, 0xef7cb8, 0xc0059d23c0, 0xc00318e030, 0xc00318e030, 0x0, 0x0)
	  server_gen.go:100  0x49
golang.org/x/tools/internal/lsp/protocol.serverDispatch(0xef7cb8, 0xc0059d23c0, 0xf0b888, 0xc00017c2a0, 0xc00318e000, 0xef7eb0, 0xc0059d20c0, 0x203000, 0xee7080, 0xc000010020)
	  tsserver.go:299  0x1b85
golang.org/x/tools/internal/lsp/protocol.ServerHandler.func1(0xef7cb8, 0xc0059d23c0, 0xc00318e000, 0xef7eb0, 0xc0059d20c0, 0xc000afbd006bef77, 0x3f797d89)
	  protocol.go:63  0xc5
golang.org/x/tools/internal/lsp/lsprpc.handshaker.func1(0xef7cb8, 0xc0059d23c0, 0xc00318e000, 0xef7eb0, 0xc0059d20c0, 0x0, 0x0)
	  lsprpc.go:560  0x452
golang.org/x/tools/internal/jsonrpc2.MustReplyHandler.func1(0xef7cb8, 0xc0059d23c0, 0xc00362b740, 0xef7eb0, 0xc0059d20c0, 0xc005ff9cf0, 0x443d36)
	  handler.go:35  0xd7
golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1.2(0xc0089fe7e0, 0xc0021ccc90, 0xc000826150, 0xef7cb8, 0xc0059d23c0, 0xc00362b740, 0xef7eb0, 0xc0059d20c0)
	  handler.go:103  0x86
created by golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1
	  handler.go:100  0x173
[Error - 2:27:32 AM] 

[hyangah]

Thanks for the report @dazoe! Transferring to the gopls issue tracker.

[gopherbot]

Change https://golang.org/cl/290789 mentions this issue: internal/lsp: handle nil pointer with import shortcut = link

[gopherbot]

Change https://golang.org/cl/292729 mentions this issue: internal/lsp: handle nil pointer with import shortcut = link