Skip to content

x/website/cmd/golangorg: will display too many identifiers as new to Go 1.16 #44178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitshur opened this issue Feb 9, 2021 · 1 comment
Closed

x/website/cmd/golangorg: will display too many identifiers as new to Go 1.16 #44178

dmitshur opened this issue Feb 9, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Member

dmitshur commented Feb 9, 2021

As reported by @benhoyt in a golang-dev thread, the "os" package documentation shows too many things as new to Go 1.16. For example, https://tip.golang.org/pkg/os/#File.Readdir is listed as new in 1.16, when it's not. This will show up on https://golang.org (without "tip.") after Go 1.16 is released.

The root cause was a bug in how godoc parses api files, described in #44081. That bug was was fixed in CL 289089. To fix golang.org, we just need to update its x/tools dependency version.
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 9, 2021
@dmitshur dmitshur added this to the Unreleased milestone Feb 9, 2021
@dmitshur dmitshur self-assigned this Feb 9, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/290609 mentions this issue: website: update to golang.org/x/[email protected]

@golang golang locked and limited conversation to collaborators Feb 10, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
website: update to golang.org/x/[email protected]
b026691 
Bring in the godoc fix made in CL 289089 with:

	go get golang.org/x/tools/godoc@61406578735f11efca21e2be93800cf530d25ecb
	go mod tidy

Fixes golang/go#44178.
Updates golang/go#44081.

Change-Id: Icaee037626e93e6fc5939b163760ad11873a3f0b
Reviewed-on: https://go-review.googlesource.com/c/website/+/290609
TryBot-Result: Go Bot <[email protected]>
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot