-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime: CPU bound goroutines cause unnecessary timer latency [1.14 backport] #39383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We don't backport performance improvements, simple or not. Although 1.14 showed a regression in timer latency for programs with soft real time constraints, the timers in 1.14 improved in other ways. This doesn't rise to the level of something that merits a backport. Sorry. |
Behavior regressions, yes. Not performance regressions. This is a performance regression. All programs continue to run as expected. Certain specific kinds of program take a small amount more time before they invoke timers. We can't promise that for each new release all programs will continue to run as fast as they did in previous releases. Of course we hope that they do. And we certainly try hard to ensure that on average programs run faster. But the fact that it is possible to write a program that runs slightly slower in a new release does not in itself constitute a regression that should be fixed. |
@ianlancetaylor did you mean to reopen this?
|
@networkimprov No, I raised the possibility of reopening it. I don't think we've made a decision. |
And the only fix we would be backporting would be the one that is already in 1.15. |
@networkimprov requested issue #38860 to be considered for backport to the next 1.14 minor release.
The text was updated successfully, but these errors were encountered: