x/build: linux-amd64-staticlockranking consistently failing

[andybons]

@danscales will golang.org/cl/207619 fix this?

linux-amd64-staticlockranking at 8c30971da654a37a5f5f211e6dccf8d83e7ee463

:: Running /workdir/go/src/make.bash with args ["/workdir/go/src/make.bash"] and env ["PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn3d0c937" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=24.1s" "GO_STAGE0_DL_DELAY=100ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64-staticlockranking" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOEXPERIMENT=staticlockranking" "GOBIN=" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/go/src

Building Go cmd/dist using /go1.4. (go1.4 linux/amd64)
Building Go toolchain1 using /go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
unknown experiment staticlockranking

go tool dist: FAILED: /workdir/go/pkg/tool/linux_amd64/asm -I /workdir/tmp/go-tool-dist-034385281/internal/cpu -I /workdir/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -D GOOS_GOARCH_linux_amd64 -gensymabis -o /workdir/tmp/go-tool-dist-034385281/internal/cpu/symabis /workdir/go/src/internal/cpu/cpu_x86.s: exit status 2
unknown experiment staticlockranking

go tool dist: FAILED: /workdir/go/pkg/tool/linux_amd64/compile -std -pack -o /workdir/tmp/go-tool-dist-034385281/runtime/internal/sys/_go_.a -p runtime/internal/sys -importcfg /workdir/tmp/go-tool-dist-034385281/runtime/internal/sys/importcfg /workdir/go/src/runtime/internal/sys/arch.go /workdir/go/src/runtime/internal/sys/arch_amd64.go /workdir/go/src/runtime/internal/sys/intrinsics.go /workdir/go/src/runtime/internal/sys/intrinsics_common.go /workdir/go/src/runtime/internal/sys/stubs.go /workdir/go/src/runtime/internal/sys/sys.go /workdir/go/src/runtime/internal/sys/zgoarch_amd64.go /workdir/go/src/runtime/internal/sys/zgoos_linux.go /workdir/go/src/runtime/internal/sys/zversion.go: exit status 2
go tool dist: open /workdir/tmp/go-tool-dist-034385281/internal/cpu/_go_.a: no such file or directory
go tool dist: open /workdir/tmp/go-tool-dist-034385281/runtime/internal/sys/_go_.a: no such file or directory
go tool dist: open /workdir/tmp/go-tool-dist-034385281/runtime/internal/atomic/_go_.a: no such file or directory
unknown experiment staticlockranking

go tool dist: FAILED: /workdir/go/pkg/tool/linux_amd64/asm -I /workdir/tmp/go-tool-dist-034385281/runtime/internal/atomic -I /workdir/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -D GOOS_GOARCH_linux_amd64 -gensymabis -o /workdir/tmp/go-tool-dist-034385281/runtime/internal/atomic/symabis /workdir/go/src/runtime/internal/atomic/asm_amd64.s: exit status 2

[danscales]

Yes, I need to check in https://go-review.googlesource.com/c/go/+/222925 (probably go in today) and https://go-review.googlesource.com/c/go/+/207619 (probably submit in another couple of days).

I'm not quite sure why @dmitshur enabled the builder before my checkins went in. Feel free to disable until my second checkin goes in -- whatever makes sense.

[dmitshur]

@andybons The failure is expected. See #37937 for context.

I enabled the builder a few days in advance of it being needed so that it would be available for SlowBots at the time the CL is ready, and so that it would start running when the relevant CL lands. This is consistent with the protocol for adding new builders in https://golang.org/wiki/PortingPolicy:

The builder must already be running (and failing, because the code is not yet in the main repository).

Maybe we need to improve the UI in build.golang.org to mark "this builder is known to not be passing yet; see tracking issue nnn".

[andybons]

@dmitshur thanks for the context. Will leave open anyway to track. @danscales can you add this issue to a Fixes line on the CL that will make the builder go green? Thank you!

[gopherbot]

Change https://golang.org/cl/207619 mentions this issue: runtime: static lock ranking for the runtime (enabled by GOEXPERIMENT)

[gopherbot]

Change https://golang.org/cl/227379 mentions this issue: dashboard, app/appengine: set a known issue for staticlockranking builder

[gopherbot]

Change https://golang.org/cl/227544 mentions this issue: dashboard: unset known issue for staticlockranking builder

[gopherbot]

Change https://golang.org/cl/244631 mentions this issue: runtime, sync: add copyright headers to new files