Skip to content

x/build/cmd/coordinator: fix ppc64le accounting in status #34990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradfitz opened this issue Oct 18, 2019 · 1 comment
Closed

x/build/cmd/coordinator: fix ppc64le accounting in status #34990

bradfitz opened this issue Oct 18, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Oct 18, 2019 •
edited
Loading

https://farmer.golang.org currently says:

"power_01" is connected from 2 machines
"power_03" is connected from 2 machines
"power_05" is connected from 2 machines
"power_02" is connected from 2 machines
"power_04" is connected from 2 machines

But that's because I misused a poorly documented status map I'd added for the Macs. It's assuming those "power_01" names are global across all buildlets, but I re-used the same hostnames for ppc64le POWER8 and POWER9.

Simple monitoring change. Need to add another map to reverseBuildletPool keyed by tuple (hostType, hostName) instead of just hostName. Filing a bug before I forget.
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 18, 2019
@bradfitz bradfitz self-assigned this Oct 18, 2019
@gopherbot gopherbot added this to the Unreleased milestone Oct 18, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 18, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/202017 mentions this issue: cmd/coordinator: fix health checking of ppc64 machines

codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@bradfitz @codebien
cmd/coordinator: fix health checking of ppc64 machines
008c9c2 
Fixes golang/go#34990
Updates golang/go#21189

Change-Id: I7f546564dd5149de6915dc631cafe3164e0e7a70
Reviewed-on: https://go-review.googlesource.com/c/build/+/202017
Reviewed-by: Bryan C. Mills <[email protected]>
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@golang golang locked and limited conversation to collaborators Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot