x/build/cmd/release: windows installer for Go 1.13.1 creates a broken link to godoc.exe

[pilkjaer]

godoc was removed from the installation as for #30029 but Windows installer still creates a link to godoc.exe in the Start menu for that script which is no longer present in the installation and results in file not found error.

What version of Go are you using (go version)?

$ go version
go version go1.13.1 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env

What did you do?

What did you expect to see?

What did you see instead?

[julieqiu]

/cc @alexbrainman @bradfitz

[WhitG]

I'm having the same issue for Windows Installer for Go 1.13.1 creating the broken link to godoc.exe

[bradfitz]

x/build/cmd/release/releaselet.go needs to only conditionally include:

    <Shortcut                                                                                                                                                                      
        Id="GoDocServerStartMenuShortcut"                                                                                                                                          
        Name="GoDocServer"                                                                                                                                                         
        Description="Starts the Go documentation server (http://localhost:6060)"                                                                                                   
        Show="minimized"                                                                                                                                                           
        Arguments='/c start "Godoc Server http://localhost:6060" "[INSTALLDIR]bin\godoc.exe" -http=localhost:6060 -goroot="[INSTALLDIR]." &amp;&amp; start http://localhost:6060'  
        Icon="gopher.ico"                                                                                                                                                          
        Target="[%ComSpec]" />                                                                                                                                                     

[gopherbot]

Change https://golang.org/cl/201201 mentions this issue: cmd/release: don't include a godoc shortcut in Windows installer

[WhitG]

Thanks for the shortcut @bradfitz
Not sure if it will be short for me though :) I'm completely brand new to programming