Skip to content

cmd/link: ErrorUnresolved provides misleading information #33979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4a6f656c opened this issue Aug 30, 2019 · 7 comments · Fixed by sthagen/golang-go#100
Closed

cmd/link: ErrorUnresolved provides misleading information #33979

4a6f656c opened this issue Aug 30, 2019 · 7 comments · Fixed by sthagen/golang-go#100
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@4a6f656c
Copy link
Contributor

Under OpenBSD -current with clang, cgo_test currently fails to build with:

# misc/cgo/test.test
misc/cgo/test(.text): relocation target __mulsc3 not defined for ABI0 (but is defined for ABI0)
misc/cgo/test(.text): relocation target __muldc3 not defined for ABI0 (but is defined for ABI0)
misc/cgo/test(.text): relocation target __absvsi2 not defined for ABI0 (but is defined for ABI0)
FAIL    misc/cgo/test [build failed]

The underlying cause is an unrelated issue that is resulting in libcompiler_rt.a not being found. However, ErrorUnresolved should not be reporting relocation target X not defined for ABI0 (but is defined for ABI0) - this is caused by the code searching the same ABI and finding a matching SXREF symbol, which is the same symbol that it is trying to resolve in the first place.

This appears to be a variant of issue #29852.
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/192597 mentions this issue: cmd/link: skip symbol references when looking for missing symbols

@katiehockman katiehockman added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 3, 2019
@katiehockman
Copy link
Contributor

/cc @cherrymui @aclements

@sthagen sthagen mentioned this issue Jan 4, 2020
Merged
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/213417 mentions this issue: Revert "cmd/link: skip symbol references when looking for missing symbols"

@aclements
Copy link
Member

Re-opened by revert CL 213417

@aclements aclements reopened this Jan 6, 2020
gopherbot pushed a commit that referenced this issue Jan 6, 2020
@aclements
Revert "cmd/link: skip symbol references when looking for missing sym…
9d3d446 
…bols"

This reverts commit 8adc1e0.

Reason for revert: The test added in this commit fails on several
builders.

Fixes #36389. Re-opens #33979.

Change-Id: I31191098c36af00f7688749b3376686673b3ac68
Reviewed-on: https://go-review.googlesource.com/c/go/+/213417
Run-TryBot: Austin Clements <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Alberto Donizetti <[email protected]>
@aclements
Copy link
Member

See #36389 for some discussion of the issue that resulted in a revert. The fix itself is almost certainly fine; it's just a problem with the test that was added.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/212764 mentions this issue: cmd/link: address failures for TestIssue33979

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/220917 mentions this issue: cmd/link: skip symbol references when looking for missing symbols

@golang golang locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/link: skip symbol references when looking for missing symbols golang/go
4 participants
@aclements @4a6f656c @gopherbot @katiehockman