Skip to content

doc/go1.13: highlight need to set GOPRIVATE when using private repos [1.13 backport] #33846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 26, 2019 · 2 comments
Closed

doc/go1.13: highlight need to set GOPRIVATE when using private repos [1.13 backport] #33846

gopherbot opened this issue Aug 26, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13

Comments

@gopherbot
Copy link
Contributor

@andybons requested issue #33796 to be considered for backport to the next 1.13 minor release.

Misspelled cherrypick. Bleh.

@gopherbot please consider this for backport to 1.13, it is a documentation change.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 26, 2019
@gopherbot gopherbot mentioned this issue Aug 26, 2019
Closed
@katiehockman katiehockman added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 26, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/191749 mentions this issue: [release-branch.go1.13] doc/go1.13: add information about using private modules to the introduction

gopherbot pushed a commit that referenced this issue Aug 26, 2019
@katiehockman
[release-branch.go1.13] doc/go1.13: add information about using priva…
8eecefd 
…te modules to the introduction

Updates #33796
Fixes #33846

Change-Id: I9f6837be96410e96d004523c48bef95ee1427484
Reviewed-on: https://go-review.googlesource.com/c/go/+/191746
Reviewed-by: Bryan C. Mills <[email protected]>
(cherry picked from commit 989409f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191749
Reviewed-by: Dmitri Shuralyov <[email protected]>
@dmitshur dmitshur added this to the Go1.13 milestone Aug 26, 2019
@gopherbot
Copy link
Contributor Author

Closed by merging 8eecefd to release-branch.go1.13.

@golang golang locked and limited conversation to collaborators Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @katiehockman