all: run 'go vet std' during run.bash, disable vetall builder

[rsc]

What the vetall builder does - run go vet on std and tell us about problems - is valuable, but hiding that in a builder makes it too easy to be surprised when it breaks. It would be better if we ran 'go vet' during run.bash (maybe during 'go test', maybe separately), so that the problems are surfaced before you get all the way to sending CLs out. Doing this would require first cleaning up std to be vet-safe.

I intend to chip away at this.

Update: Based on discussion below, my concrete suggestion is:

• Fix all the vet issues in GOROOT so there are no whitelists left.
• Make 'go test' on packages in GOROOT run all vet checks, not just the usual subset.
  This will help people catch problems on their native GOOS/GOARCH during regular development.
• Make sure misc-compile* trybots have complete GOOS/GOARCH coverage.
• Make those trybots also run vet for their GOOS/GOARCH.
  This will help keep detecting build breakages, which is a side effect of the current vetall builder.
• Retire the vetall builder.

[ianlancetaylor]

For what it's worth, where the vetall builder always catches me is other GOARCH GOOS values.

[bradfitz]

What Ian said. I think that's why Josh added it, too.

Don't we already run go vet std effectively via in run.bash by running the tests? The only ones where we don't might be the packages that lack tests.

/cc @josharian

[josharian]

In addition to what Ian said, 'go vet' doesn't run all the vet checks; the vetall builder does. That's why there is still a set of whitelists, despite 'go vet' running on all packages in std as part of 'go test'.

To be clear, I'm definitely in favor of fixing things so that the whitelists eventually disappear, moving vet checks to places that they always get run (#17544), etc.

These comments about why we still have a vetall builder are to help clarify scope.

[gopherbot]

Change https://golang.org/cl/176104 mentions this issue: syscall: fix vet complaints for all dragonfly, freebsd, netbsd, openbsd

[gopherbot]

Change https://golang.org/cl/176111 mentions this issue: cmd/link: use standard-syntax struct tags in large-tag test

[gopherbot]

Change https://golang.org/cl/176106 mentions this issue: runtime, crypto/x509: fix vet complaints for all windows

[gopherbot]

Change https://golang.org/cl/176105 mentions this issue: runtime: fix vet complaints for all freebsd, netbsd, openbsd

[gopherbot]

Change https://golang.org/cl/176099 mentions this issue: runtime: fix vet complaints for linux/386

[gopherbot]

Change https://golang.org/cl/176100 mentions this issue: runtime: fix vet complaints for linux/amd64

[gopherbot]

Change https://golang.org/cl/176102 mentions this issue: runtime: fix vet complaints for linux/arm64, linux/mips*, linux/ppc64*, linux/s390x

[gopherbot]

Change https://golang.org/cl/176103 mentions this issue: runtime: fix vet complaints for solaris/amd64, illumos/amd64

[gopherbot]

Change https://golang.org/cl/176110 mentions this issue: encoding/gob: rename encBuffer.WriteByte to writeByte

[gopherbot]

Change https://golang.org/cl/176108 mentions this issue: cmd/internal/bio: rename Reader.Seek to MustSeek