cmd/doc: not printing package name in type query

[rsc]

go doc big.NewInt tells me what package it is talking about:

$ go doc big.NewInt
package big // import "math/big"

func NewInt(x int64) *Int
    NewInt allocates and returns a new Int set to x.

$ 

but go doc big.Int does not:

$ go doc big.Int
type Int struct {
	// Has unexported fields.
}
    An Int represents a signed multi-precision integer. The zero value for an
    Int represents the value 0.

    Operations always take pointer arguments (*Int) rather than Int values, and
    each unique Int value requires its own unique *Int pointer. To "copy" an Int
    value, an existing (or newly allocated) Int must be set to a new value using
    the Int.Set method; shallow copies of Ints are not supported and may lead to
    errors.

func NewInt(x int64) *Int
func (z *Int) Abs(x *Int) *Int
func (z *Int) Add(x, y *Int) *Int
...

It seems like the package line should be printed always, and there is just a bug in this code path.

/cc @robpike

[robpike]

There's inconsistency for sure; this one doesn't print the package either:

% go doc fmt.printf
func Printf(format string, a ...interface{}) (n int, err error)
    Printf formats according to a format specifier and writes to standard
    output. It returns the number of bytes written and any write error
    encountered.

% 

Should the package always be printed? Maybe. Or maybe just if the arguments don't match the package name?

There's also this, which is annoying. If I run that command in my home directory, not in a module directory, I get a distracting message containing nothing mentioned on the command line:

bismarck=% go doc fmt.printf
warning: pattern "all" matched no module dependencies
func Printf(format string, a ...interface{}) (n int, err error)
...

[gopherbot]

Change https://golang.org/cl/177797 mentions this issue: cmd/doc: always print package clause except for commands

[gopherbot]

Change https://golang.org/cl/182619 mentions this issue: doc: add release notes for godoc and go doc

[gopherbot]

Change https://golang.org/cl/206128 mentions this issue: cmd/doc: show the package clause always