Skip to content

make.bash is incompatible with ccache #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Feb 23, 2012 · 3 comments
Closed

make.bash is incompatible with ccache #3112

gopherbot opened this issue Feb 23, 2012 · 3 comments

Comments

@gopherbot
Copy link
Contributor

What steps will reproduce the problem?
1. CC="ccache gcc" ./make.bash

What is the expected output?
Successful compilation

What do you see instead?
ccache: invalid option -- 'o'
...
go tool dist: FAILED: ccache -o ...

Which compiler are you using (5g, 6g, 8g, gccgo)?
8g

Which operating system are you using?
Linux

Which revision are you using?  (hg identify)
96bd78e7d35e weekly/weekly.2012-02-22

Please provide any additional information below.

It should be "ccache gcc -o ..." instead of "ccache -o ....".
@bytbox
Copy link
Contributor

bytbox commented Feb 23, 2012

Comment 1:

This is an issue with cmd/dist.
Currently the behavior is to append the other arguments in CC (["gcc"], in this case)
/after/ "-o xyz". At build.c:633
vadd(&link, gccargs.p[0]);
vadd(&link, "-o");
vadd(&link, bpathf(&b, "%s/%s%s", tooldir, name, exe));
vcopy(&link, gccargs.p+1, gccargs.len-1);http://golang.org/cl/5700044
I have a CL to change this at http://golang.org/cl/5700044, but it may break
some other wanted behavior. Perhaps we should pay attention to CFLAGS?

@rsc
Copy link
Contributor

rsc commented Feb 23, 2012

Comment 2:

I am enjoying life without $CFLAGS.  Your CL is fine.

@rsc
Copy link
Contributor

rsc commented Feb 23, 2012

Comment 3:

This issue was closed by revision 7ae6872.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants