cmd/cgo: CL 159258 breaks netbsd build

[mikioh]

See https://build.golang.org/log/3f7798c6e6550ebbc90d6dedc51f9478cd5df2b2

##### ../misc/cgo/life
PASS

##### ../misc/cgo/test
# misc/cgo/test [misc/cgo/test.test]
./issue29878.go:16:6: cannot use _Cfunc_issue29878function(arg) (type _Ctype_short) as type int16 in assignment
./issue29878.go:16:38: cannot use arg (type uint32) as type _Ctype_uint in argument to _Cfunc_issue29878function
FAIL	misc/cgo/test [build failed]
2019/03/19 05:09:19 Failed: exit status 2
# misc/cgo/test [misc/cgo/test.test]
./issue29878.go:16:6: cannot use _Cfunc_issue29878function(arg) (type _Ctype_short) as type int16 in assignment
./issue29878.go:16:38: cannot use arg (type uint32) as type _Ctype_uint in argument to _Cfunc_issue29878function
FAIL	misc/cgo/test [build failed]
2019/03/19 05:09:20 Failed: exit status 2
# misc/cgo/test [misc/cgo/test.test]
./issue29878.go:16:6: cannot use _Cfunc_issue29878function(arg) (type _Ctype_short) as type int16 in assignment
./issue29878.go:16:38: cannot use arg (type uint32) as type _Ctype_uint in argument to _Cfunc_issue29878function
FAIL	misc/cgo/test [build failed]
2019/03/19 05:09:20 Failed: exit status 2
PASS
ok  	misc/cgo/testtls	0.006s
skipped due to earlier error
2019/03/19 05:09:23 FAILED

[ianlancetaylor]

CC @phst

[ianlancetaylor]

Odd. That is exactly what I would expect to see if the build were running cgo with the new test but without the new patch.

[ianlancetaylor]

This may be because the NetBSD <stdint.h> file defines uint8_t and friends using #define rather than typedef.

[gopherbot]

Change https://golang.org/cl/168337 mentions this issue: cmd/cgo: accept __uint8_t as the uint8_t type

[ianlancetaylor]

CL 168337 may fix this problem, but we don't seem to have a working NetBSD gomote so I can't test it.

[krytarowski]

This may be because the NetBSD <stdint.h> file defines uint8_t and friends using #define rather than typedef.

It's compliant solution... but we have switched it to a saner format now. It caused fallout in various code.