You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
$ go version
go version devel +c5d38b896d Thu Aug 23 06:10:48 2018 +0000 linux/amd64
$ go list -f {{.SFiles}} math/big
[arith_amd64.s]
$ go vet -x math/big
...
cat >$WORK/b001/vet.cfg << 'EOF' # internal
{
"Dir": "/home/adonovan/go/src/math/big",
"ImportPath": "math/big",
"GoFiles": [
"/home/adonovan/go/src/math/big/accuracy_string.go",
...,
],
...,
}
EOF
...
Some vet checks, such as asmdecl and buildtag, apply equally to the Go files and non-Go files of a package. However, the .cfg file that go vet passes to cmd/vet does not mention them, so these checks are incomplete or ineffective.
The .cfg file should contain a field NonGoFiles that lists the package source files written in assembly, C, Fortran, and all the other benighted languages.
The text was updated successfully, but these errors were encountered:
- add a no-op -tags flag for legacy compatibility.
Tags processing is done by go vet, but it passes the flag on.
Exercised by cmd/go TestGoVetWithTags.
- rename OtherFiles to NonGoFiles in the JSON *.cfg file, to match
the name actually used for this field (see github.com/golang/go/issues/27665).
We really need to publish the types for this protocol.
Exercised by cmd/go TestScript/vet_asm.
- suppress diagnostics in cfg.VetxOnly mode.
Exercised by cmd/go TestTestVet.
Change-Id: I63259f1bd01531d110362e38190a220389b2ec4b
Reviewed-on: https://go-review.googlesource.com/c/149608
Run-TryBot: Alan Donovan <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Michael Matloob <[email protected]>
Some vet checks, such as asmdecl and buildtag, apply equally to the Go files and non-Go files of a package. However, the .cfg file that
go vet
passes to cmd/vet does not mention them, so these checks are incomplete or ineffective.The .cfg file should contain a field
NonGoFiles
that lists the package source files written in assembly, C, Fortran, and all the other benighted languages.The text was updated successfully, but these errors were encountered: