cmd/go: short tests are not short enough

[rsc]

Running all.bash (which does go test -short std cmd), my target is usually that individual tests should run in under 1 second.

The cmd/go tests will never reach this target - cmd/go does more than perhaps the entire standard library combined, so it's fine to take more than 1 second. But my usual target is to keep it below 30s, if not 20s. Right now it's at 76s. We should keep bringing that down.

Converting more tests to scripts may help.

[iamoryanmoshe]

Would love to give it a shot, can you please explain what

Converting more tests to scripts

Mean?

[bcmills]

See src/cmd/go/testdata/script.

(The .txt files are pretty self-explanatory, but the README contains more detail about the format and supported commands.)

[shivakumargn]

There are several cmd/go tests in go_test.go. Will submit CL for three of the most time consuming tests listed below. Additionally, will make them non-short.

TestCpuprofileTwice (8.55s)
TestCoverpkgAllRuntime (27.87s)
TestAtomicCoverpkgAll (28.72s)

[gopherbot]

Change https://golang.org/cl/126636 mentions this issue: cmd/go: 3 cmd/go tests (>8s) made as non-short scripts

[iwdgo]

cmd/go times out on my Windows 10 but I noticed that -vet off could be set. During distribution, running vet has limited value and it is tested separately anyway. The fix seems elementary.
Added:
Recently added GOFLAGS allows to set vet off everywhere if needed: GOFLAGS=-vet=off
No fix needed.

[gopherbot]

Change https://golang.org/cl/127542 mentions this issue: cmd/dist: removing vet during testing of build

[bcmills]

We're currently at 37s for go test -short cmd/go on my workstation. Getting better, but still not quite at the goal.