Skip to content

cmd/link: Darwin build fails with "unknown load command" [1.10 backport] #25912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jun 15, 2018 · 2 comments
Closed

cmd/link: Darwin build fails with "unknown load command" [1.10 backport] #25912

gopherbot opened this issue Jun 15, 2018 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10.4

Comments

@gopherbot
Copy link
Contributor

@mistydemeo requested issue #25908 to be considered for backport to the next 1.10 minor release.

@gopherbot please consider this for backport to 1.10, it's a regression
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 15, 2018
@gopherbot gopherbot mentioned this issue Jun 15, 2018
Closed
@gopherbot gopherbot added this to the Go1.10.4 milestone Jun 15, 2018
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/119215 mentions this issue: [release-branch.go1.10] ld/macho: add all missing load commands

@bradfitz bradfitz added the CherryPickApproved Used during the release process for point releases label Jun 15, 2018
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 15, 2018
@gopherbot
Copy link
Contributor Author

Closed by merging 3d59583 to release-branch.go1.10.

gopherbot pushed a commit that referenced this issue Jun 15, 2018
@mistydemeo @bradfitz
[release-branch.go1.10] ld/macho: add all missing load commands
3d59583 
The ld/macho code currently understands a subset of the mach-o load
commands. I've encountered one of these in the wild in a Go-produced
binary, which tripped up the Go linker because its switch statement
expects its list of load commands to be exhaustive; the rest I've
added for the sake of completion.

The ruby-macho library is a good non-Darwin header resource for these:
https://github.com/homebrew/ruby-macho

Fixes #25912

Change-Id: Ib54c065d27e87d8726a9870df05a2bae24828b98
GitHub-Last-Rev: 655e3f4
GitHub-Pull-Request: #25906
Reviewed-on: https://go-review.googlesource.com/119115
Reviewed-by: Ian Lance Taylor <[email protected]>
(cherry picked from commit 1a92cdb)
Reviewed-on: https://go-review.googlesource.com/119215
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@adamdecaf adamdecaf mentioned this issue Jun 27, 2018
Closed
@golang golang locked and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10.4
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot