-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Open
Labels
Buildersx/build issues (builders, bots, dashboards)x/build issues (builders, bots, dashboards)NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Description
Currently if there are N builds waiting on a buildlet type (due to lack of machines or quota), the current implementation is a bunch of goroutines fighting over a mutex.
It's random who wins and gets the buildlet.
We should have them register interest and when a buildlet becomes available, pick the highest priority one.
Example priorities in order:
- trybot run with a +2 already
- trybot run
- normal run of a build at tip of a release branch
- normal run of a build at tip of master branch
- normal run of a build at tip of dev branch
- normal run of a build not at tip
- idle flake detection (x/build: auto-detect flakes #19177)
etc.
/cc @danp @kevinburke
dmitshur, heschi, OneOfOne and bcmills
Metadata
Metadata
Assignees
Labels
Buildersx/build issues (builders, bots, dashboards)x/build issues (builders, bots, dashboards)NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.