cmd/compile: backport CL 36256 to 1.8 (s390x SSA issue) #18958
Labels
Comments
gopherbot
pushed a commit
that referenced
this issue
Feb 6, 2017
…x SSA rules This CL fixes two issues: 1. Load ops were initially always lowered to unsigned loads, even for signed types. This was fine by itself however LoadReg ops (used to re-load spilled values) were lowered to signed loads for signed types. This meant that spills could invalidate optimizations that assumed the original unsigned load. 2. Types were not always being maintained correctly through rules designed to eliminate unnecessary zero and sign extensions. Updates #18906 and fixes #18958 (backport of CL 36256 to 1.8). Change-Id: Id44953b0f644cad047e8474edbd24e8a344ca9a7 Reviewed-on: https://go-review.googlesource.com/36350 Reviewed-by: Brad Fitzpatrick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'd like to backport the fix for #18906 (CL 36256) to 1.8. The bug is a regression from 1.7. This issue is for tracking the backport.
I've sent CL 36350 which is CL 36256 cherry-picked onto release-branch.go1.8.
The text was updated successfully, but these errors were encountered: