Skip to content

strings: assembly optimization causes regression in functionality #15679

Closed
@dsnet

Description

@dsnet

Commit 6b02a19 caused a regression in the strings package that causes some tests to fail.

A simple test to exercise this behavior is the following:

strings.Contains("abcdef?v=profileM", "abcdef?v=profile&")

On go1.6, this returns false as expected.
On 6b02a19, this returns true, which is incorrect.

/cc @rsc, @TocarIP, @nigeltao

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions