misc/trace: switch back to lean config #15302
Labels
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
gopherbot
pushed a commit
that referenced
this issue
Apr 14, 2016
The old trace-viewer is broken since Chrome 49: https://bugs.chromium.org/p/chromium/issues/detail?id=569417 It was fixed in: catapult-project/catapult@506457c This change updates trace-viewer to the latest version (now it is called catapult). This version has a bug in the lean config that we use, though: catapult-project/catapult#2247 So use full config for now (it works, but leads to larger html). When the bug is fixed we need to switch back to lean config (issue #15302). Change-Id: Ifb8d782ced66e3292d81c5604039fe18eaf267c5 Reviewed-on: https://go-review.googlesource.com/22013 Reviewed-by: Brad Fitzpatrick <[email protected]>
|
Change https://golang.org/cl/58750 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Aug 25, 2017
Generated with github.com/catapult/tracing/bin/vulcanize_trace_viewer catapult @ ab4d571fa Renamed trace_viewer_lean.html to trace_viewer_full.html to make it clear we are using the full version of trace viewer (waiting for catapult-project/catapult#2247 to be fixed). Update #15302 Change-Id: Ice808bb27ab79a1dec9fc863e0c5a761027ebfbe Reviewed-on: https://go-review.googlesource.com/58750 Reviewed-by: Dmitry Vyukov <[email protected]>
ALTree
added
the
NeedsFix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://go-review.googlesource.com/#/c/22013 updates trace-viewer to newer revision (required to unbreak visualization in chrome). But trace-viewer (catapult) is broken itself at the moment:
catapult-project/catapult#2247
So the change uses full config instead of lean config. Full config works, but leads to larger html.
We need to switch back to lean config when the bug is fixed.
The text was updated successfully, but these errors were encountered: