x/crypto/ssh/terminal: ReadPassword not supported on Solaris

[fazalmajid]

Possibly irrelevant if #12101 is implemented.

I am working on a util_solaris.go to provide Solaris equivalents for the code in util.go, using the high-level APIs provided in x/sys/unix, e.g. unix.IoctlSetTernio. I am not sure if there are rules against importing x/sys/unix in x/sys/crypto. The Linux/BSD implementation in util.go uses syscall, but the requisite Solaris syscalls are apparently only available in x/sys/unix.

[minux]

It's fine for x/crypto to import x/sys. Ther no extern code import restriction is only on the standard library and select few packages that are vendored into std. x/crypto/ssh/terminal is not one of them.

[gopherbot]

CL https://golang.org/cl/16722 mentions this issue.

[fazalmajid]

@slackpad As an interim measure until the CL is approved by the Go maintainers, you can just drop the file https://go-review.googlesource.com/#/c/16722/2/ssh/terminal/util_solaris.go into your src/golang.org/x/crypto/ssh/terminal directory to get apps to compile.

[slackpad]

Thanks @fazalmajid for the suggestion!