Skip to content

Commit f0fa13b

Browse files
fraenkelbroady
authored andcommitted
[release-branch.go1.6] net/http: multipart ReadForm close file after copy
Always close the file regardless of whether the copy succeeds or fails. Pass along the close error if the copy succeeds Updates #16296 Change-Id: Ib394655b91d25750f029f17b3846d985f673fb50 Reviewed-on: https://go-review.googlesource.com/30410 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-on: https://go-review.googlesource.com/33640 Reviewed-by: Chris Broadfoot <[email protected]>
1 parent da6b9ec commit f0fa13b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/mime/multipart/formdata.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,10 @@ func (r *Reader) ReadForm(maxMemory int64) (f *Form, err error) {
7575
if err != nil {
7676
return nil, err
7777
}
78-
defer file.Close()
7978
_, err = io.Copy(file, io.MultiReader(&b, p))
79+
if cerr := file.Close(); err == nil {
80+
err = cerr
81+
}
8082
if err != nil {
8183
os.Remove(file.Name())
8284
return nil, err

0 commit comments

Comments
 (0)