Revert "cmd/compile: make logopt test skip if cannot create scratch directory"

alexbrainman · dr2chase · commit df15eaedd0f4 · 2020-04-11T13:49:21.000Z
This reverts commit 9853481. Reason for revert: The change does not really fixes issue #38251. CL 227497 is real fix. Change-Id: I9f556005baf1de968f059fb8dad89dae05330aa6 Reviewed-on: https://go-review.googlesource.com/c/go/+/227802 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com>
diff --git a/src/cmd/compile/internal/logopt/logopt_test.go b/src/cmd/compile/internal/logopt/logopt_test.go
@@ -62,7 +62,7 @@ func TestLogOpt(t *testing.T) {
 
 	dir, err := ioutil.TempDir("", "TestLogOpt")
 	if err != nil {
-		t.Skipf("Could not create work directory, assuming not allowed on this platform.  Error was '%v'", err)
+		t.Fatal(err)
 	}
 	defer os.RemoveAll(dir)
 

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ func TestLogOpt(t *testing.T) {`
`62`	`62`
`63`	`63`	`dir, err := ioutil.TempDir("", "TestLogOpt")`
`64`	`64`	`if err != nil {`
`65`		`- t.Skipf("Could not create work directory, assuming not allowed on this platform. Error was '%v'", err)`
	`65`	`+ t.Fatal(err)`
`66`	`66`	`}`
`67`	`67`	`defer os.RemoveAll(dir)`
`68`	`68`