cmd/compile: make logopt test skip if cannot create scratch directory

dr2chase · dr2chase · commit 98534812bdcd · 2020-04-06T15:22:07.000Z
Fixes #38251. Change-Id: Ic635843fb503484a1c9a230b0cca571393d3da5a Reviewed-on: https://go-review.googlesource.com/c/go/+/227339 Run-TryBot: David Chase <drchase@google.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
diff --git a/src/cmd/compile/internal/logopt/logopt_test.go b/src/cmd/compile/internal/logopt/logopt_test.go
@@ -51,7 +51,7 @@ func TestLogOpt(t *testing.T) {
 
 	dir, err := ioutil.TempDir("", "TestLogOpt")
 	if err != nil {
-		t.Fatal(err)
+		t.Skipf("Could not create work directory, assuming not allowed on this platform.  Error was '%v'", err)
 	}
 	defer os.RemoveAll(dir)
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ func TestLogOpt(t *testing.T) {`
`51`	`51`
`52`	`52`	`dir, err := ioutil.TempDir("", "TestLogOpt")`
`53`	`53`	`if err != nil {`
`54`		`- t.Fatal(err)`
	`54`	`+ t.Skipf("Could not create work directory, assuming not allowed on this platform. Error was '%v'", err)`
`55`	`55`	`}`
`56`	`56`	`defer os.RemoveAll(dir)`
`57`	`57`