Skip to content

Commit be9612a

Browse files
committed
[dev.regabi] os: disable TestDirFS until #42637 is fixed
This test is causing nearly every trybot run on dev.regabi and dev.typeparams to fail. It's already a release blocker for Go 1.16, so the failures on the development branches is entirely noise; and because it causes the trybots to short-circuit, it risks masking actual Windows-specific failures. This CL disables the test until a proper solution is decided upon and implemented for Go 1.16. Updates #42637. Change-Id: Ibc85edaed591f1c125cf0b210867aa89d2b0a4b6 Reviewed-on: https://go-review.googlesource.com/c/go/+/286213 Run-TryBot: Matthew Dempsky <[email protected]> Trust: Matthew Dempsky <[email protected]> Trust: Robert Griesemer <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Reviewed-by: Robert Griesemer <[email protected]>
1 parent 8ee3d39 commit be9612a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/os/os_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2689,6 +2689,9 @@ func TestOpenFileKeepsPermissions(t *testing.T) {
26892689
}
26902690

26912691
func TestDirFS(t *testing.T) {
2692+
if runtime.GOOS == "windows" {
2693+
t.Skip("workaround for dev.regabi/dev.typeparams until #42637 is fixed")
2694+
}
26922695
if err := fstest.TestFS(DirFS("./testdata/dirfs"), "a", "b", "dir/x"); err != nil {
26932696
t.Fatal(err)
26942697
}

0 commit comments

Comments
 (0)