cmd/go/internal/modload: close modules.txt

testwill · matloob · commit b6efc3b755b7 · 2024-04-02T20:07:23.000Z
Change-Id: Ieb4cf76f4d7050d2f3052c2f90e47901de74d641 GitHub-Last-Rev: 1e8dcfd GitHub-Pull-Request: #66629 Reviewed-on: https://go-review.googlesource.com/c/go/+/575475 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
diff --git a/src/cmd/go/internal/modload/init.go b/src/cmd/go/internal/modload/init.go
@@ -1465,6 +1465,7 @@ func modulesTextIsForWorkspace(vendorDir string) (bool, error) {
 	if err != nil {
 		return false, err
 	}
+	defer f.Close()
 	var buf [512]byte
 	n, err := f.Read(buf[:])
 	if err != nil && err != io.EOF {

Original file line number	Diff line number	Diff line change
`@@ -1465,6 +1465,7 @@ func modulesTextIsForWorkspace(vendorDir string) (bool, error) {`
`1465`	`1465`	`if err != nil {`
`1466`	`1466`	`return false, err`
`1467`	`1467`	`}`
	`1468`	`+ defer f.Close()`
`1468`	`1469`	`var buf [512]byte`
`1469`	`1470`	`n, err := f.Read(buf[:])`
`1470`	`1471`	`if err != nil && err != io.EOF {`