Skip to content

Commit 9e7ea35

Browse files
author
Bryan C. Mills
committed
runtime: expand TestGdbPythonCgo skip to include mips64le
The failure mode in #37794 does not match the failure mode described in #18784. However, since the test is currently skipped on all other MIPS variants, it may be that they suffer from the same underlying GDB bug. Ideally one of the Go MIPS maintainers should file an upstream bug and remove the skip once it is fixed; in the meantime, there is no point in continuing to let the test fail on just one of the four MIPS variants. For #37794 Change-Id: I570f51cc04cbb7ef1ed7efd526e26886af53bfb6 Reviewed-on: https://go-review.googlesource.com/c/go/+/376654 Trust: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: Cherry Mui <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 931e84a commit 9e7ea35

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/runtime/runtime-gdb_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ func TestGdbPython(t *testing.T) {
153153
}
154154

155155
func TestGdbPythonCgo(t *testing.T) {
156-
if runtime.GOARCH == "mips" || runtime.GOARCH == "mipsle" || runtime.GOARCH == "mips64" {
157-
testenv.SkipFlaky(t, 18784)
156+
if strings.HasPrefix(runtime.GOARCH, "mips") {
157+
testenv.SkipFlaky(t, 37794)
158158
}
159159
testGdbPython(t, true)
160160
}

0 commit comments

Comments
 (0)